Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

penalty for reopened issue #462

Merged
merged 12 commits into from
Jul 31, 2023
Merged

penalty for reopened issue #462

merged 12 commits into from
Jul 31, 2023

Conversation

Venoox
Copy link
Contributor

@Venoox Venoox commented Jul 5, 2023 •
edited
Loading

@netlify
Copy link

netlify bot commented Jul 5, 2023 •
edited
Loading

✅ Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit bfa3583
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/64c7534344acb4000890ed1e
😎 Deploy Preview https://deploy-preview-462--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Venoox Venoox marked this pull request as ready for review July 16, 2023 18:01
@Venoox Venoox requested a review from 0xcodercrane as a code owner July 16, 2023 18:01
0x4007
0x4007 reviewed Jul 16, 2023
View reviewed changes
src/bindings/config.ts Outdated Show resolved Hide resolved
0x4007
0x4007 previously approved these changes Jul 27, 2023
View reviewed changes
@0x4007 0x4007 enabled auto-merge July 27, 2023 16:22
@0x4007
Copy link
Member

0x4007 commented Jul 27, 2023

@Venoox it looks like this pull request might have been forgotten about sorry for the delay. I enabled auto merge.

@0xcodercrane 0xcodercrane requested a review from rndquu July 28, 2023 01:43
@0xcodercrane
Copy link
Contributor

@Venoox needs to resolve conflicts if the PR gets merged automatically

auto-merge was automatically disabled July 28, 2023 18:00

Head branch was pushed to by a user without write access

@0x4007 0x4007 enabled auto-merge July 30, 2023 03:11
@0x4007
Copy link
Member

0x4007 commented Jul 30, 2023 •
edited
Loading

Hey @Venoox it looks like you just need to resolve the conversations to merge your pull request in!

You might need to also reassign yourself to get credit for the issue.

@Venoox
Copy link
Contributor Author

Venoox commented Jul 30, 2023

@pavlovcik can I just resolve conversations by myself? I always thought it should be the person who started the review that should resolve it :D

@0xcodercrane
Copy link
Contributor

@pavlovcik can I just resolve conversations by myself? I always thought it should be the person who started the review that should resolve it :D

Thank you to follow up. Let me help you to resolve the conversations. no worries

@0xcodercrane
Copy link
Contributor

Conversations have been resolved now. but still have a couple of conflicts. @Venoox

auto-merge was automatically disabled July 31, 2023 06:22

Head branch was pushed to by a user without write access

@0xcodercrane 0xcodercrane enabled auto-merge July 31, 2023 07:27
@0xcodercrane 0xcodercrane added this pull request to the merge queue Jul 31, 2023
Merged via the queue into ubiquity:development with commit 272108b Jul 31, 2023
@wannacfuture wannacfuture mentioned this pull request Aug 11, 2023
Closed
@0x4007 0x4007 linked an issue Aug 17, 2023 that may be closed by this pull request
Change Wallet Permit Generation Exploit #483
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@molecula451 molecula451 molecula451 left review comments

@0xcodercrane 0xcodercrane 0xcodercrane approved these changes

@0x4007 0x4007 0x4007 left review comments

@rndquu rndquu Awaiting requested review from rndquu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Wallet Permit Generation Exploit Penalty for reopened issues
5 participants
@Venoox @0x4007 @0xcodercrane @molecula451 @rndquu