fix: moved to yarn classic #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4007
reviewed
Jul 31, 2024
| env: | ||
| NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
|
I have no experience with this. |
Keyrxng
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
I don't see any issue with this, I was never against either version but I do think we should start using the packageManager field religiously. It's purpose is to prevent "works on my machine" issues and it's been a problem in CI a few times
I am too unskilled to understand how it works
I feel the same, clearly V4 has perks but it's a bit of a nightmare to use vs V1
|
@Keyrxng Sure agreed, we can start putting the classic package version there moving forward. But yeah v4 has been painful to use so far it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I am too unskilled to understand how it works but I could not get yarn 4 to publish a package with credentials through a CLI. I kept having a
YN0033error for authentication, which is not documented. Yarn berry under the hood is supposed to usenpm publish, so it should have been working.In the end I just reverted to Yarn classic which is supposed to work. If it still doesn't, it means the token itself is invalid.
It is on purpose that this PR target
main, to trigger the publish and test. If it works I'll merge back todevelop.