rpc-handler fix knip issues

[gitcoindev]

Resolves #12

QA: https://github.com/gitcoindev/rpc-handler/actions/runs/9164829604

Knip workflow and all findings should be fixed after merging this PR.

I removed node-fetch from direct dependencies as I found references only in node_modules transitive dependencies.

[github-actions]

Lines	Statements	Branches	Functions
	Unknown% (0/0)	Unknown% (0/0)	Unknown% (0/0)

JUnit

Tests	Skipped	Failures	Errors	Time
0	0 💤	0 ❌	0 🔥	2.932s ⏱️

Coverage Report (0%)

File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
All files	0	0	0	0

[gitcoindev]

@rndquu , @molecula451 I assume the failed tests were fixed in #6 by @Keyrxng .

[rndquu]

@gitcoindev

Could you:

1. Merge the latest development branch and resolve conflicts
2. Bring back the node-fetch package. It is used by the lib/chainlist github submodule here. Besides I got the build error "node-fetch is missing" without this package to be mentioned explicitly in package.json.

[gitcoindev]

@gitcoindev

Could you:

1. Merge the latest development branch and resolve conflicts
2. Bring back the node-fetch package. It is used by the lib/chainlist github submodule here. Besides I got the build error "node-fetch is missing" without this package to be mentioned explicitly in package.json.

@rndquu thank you for checking this. I synced my fork to the latest development branch and rebased against it, removing two commits from the pr branch. I force pushed the branch this time to avoid clutter, I would be grateful if you checked again.

[rndquu]

There is too much hurdle with knip. It doesn't work as expected. Check this ci run and these errors:

Unused files (2)
src/services/rpc-service.ts
src/services/storage-service.ts

rpc-service.ts and storage-service.ts are clearly used here and here.

Unused dependencies (2)
axios package.json
node-fetch package.json

axios is used here.

At this point it makes sense to stop using knip and remove it completely (at least from this repo) because maintaining knip's CI workflow gets down to ignoring certain files that are definitely part of the project.

[gitcoindev]

@rndquu I have just seen it, will try to fix configuration. Once it is fixed, I do not think much maintenance will be needed.

[gitcoindev]

@rndquu I have just seen it, will try to fix configuration. Once it is fixed, I do not think much maintenance will be needed.

I was able to reproduce and fix configuration locally, just pushed an update.

[rndquu]

@gitcoindev Do we need the following steps (one, two, three, four) if Knip-reporter workflow simply downloads and displays the results?

I'm this picky because knip-reporter runs in a privileged context with access to org secrets (because of on: workflow_run) and yarn isntall here could be utilized to exfiltrate secrets should we miss a PR with malicious code in the development branch which is checked out here.

[gitcoindev]

@gitcoindev Do we need the following steps (one, two, three, four) if Knip-reporter workflow simply downloads and displays the results?

I'm this picky because knip-reporter runs in a privileged context with access to org secrets (because of on: workflow_run) and yarn isntall here could be utilized to exfiltrate secrets should we miss a PR with malicious code in the development branch which is checked out here.

You are picky but right. I will check this in the next 2 hours. It should be possible to skip those steps.

[gitcoindev]

All right! I was able to test this at gitcoindev#5 , will push a follow up commit asap.

[gitcoindev]

@rndquu I removed the steps at 759fb4d , please check again.

[gitcoindev]

QA CI with steps removed: https://github.com/gitcoindev/rpc-handler/actions/runs/9178339860/job/25238013021

[rndquu]

@gitcoindev Works fine, thank you