Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: faq button #263

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix: faq button #263

merged 1 commit into from
Jul 22, 2024
+5,837 −8,640

Conversation

0x4007
Copy link
Member

@0x4007 0x4007 commented Jul 19, 2024 •
edited
Loading

Resolves #261

Restructured the footer and made all svgs inherit their fills due to light/dark mode.

@0x4007 0x4007 marked this pull request as ready for review July 19, 2024 04:16
@0x4007 0x4007 requested a review from Keyrxng as a code owner July 19, 2024 04:16
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Jul 19, 2024 •
edited
Loading

This was referenced Jul 19, 2024
Merged
Merged
Keyrxng
Keyrxng approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@Keyrxng Keyrxng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was better that the icon be more prominent matching the pagination as opposed to the build tag but I see where you are coming from especially when pagination is not visible

P.S I'd merge this first then the sync PR with these changes included right? Or would just merging the bigger one with both be the way to do it?

@0x4007 0x4007 merged commit 80c5451 into ubiquity:development Jul 22, 2024
8 checks passed
@0x4007 0x4007 deleted the fix/erc20-token-permit-script branch July 22, 2024 21:50
@ubiquibot-dev ubiquibot-dev bot mentioned this pull request Jul 22, 2024
Closed
@0x4007
Copy link
Member Author

0x4007 commented Jul 22, 2024

Merge order doesn't matter as much as you think it does. Besides these changes are included in the other pulls.

I assumed we would have merged them in faster which is why I included these in the other pulls too to move things along quicker.

@Keyrxng
Copy link
Member

Keyrxng commented Jul 22, 2024

Merge order doesn't matter as much as you think it does.

That takes some weight off actually, good to know.

I assumed we would have merged them in faster which is why I included these in the other pulls too to move things along quicker.

Ah okay I got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keyrxng Keyrxng Keyrxng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect faq button implementation
2 participants
@0x4007 @Keyrxng