Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new deploy workflow to use new naming #253

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

EresDev
Copy link
Contributor

@EresDev EresDev commented Jun 18, 2024

Resolves ubiquity/cloudflare-deploy-action#13 (comment)

Github uses deploy.yml only from the default branch development. We need this in the default branch to work for both, our new and old code from #226

Can we merge this asap to try it?

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Jun 18, 2024

Copy link
Contributor

github-actions bot commented Jun 18, 2024

@EresDev EresDev changed the base branch from development to beta June 18, 2024 12:50
@EresDev EresDev changed the base branch from beta to development June 18, 2024 14:24
@EresDev EresDev requested review from rndquu and Keyrxng and removed request for Keyrxng June 18, 2024 14:25
@EresDev EresDev marked this pull request as ready for review June 18, 2024 14:32
@EresDev EresDev requested a review from Keyrxng as a code owner June 18, 2024 14:32
@rndquu rndquu merged commit c124c0a into ubiquity:development Jun 18, 2024
@rndquu
Copy link
Member

rndquu commented Jun 18, 2024

@EresDev https://github.com/ubiquity/pay.ubq.fi/actions/runs/9567051444/attempts/1

It seems the project was uploaded to cloudflare but the CI failed on posting a comment in a PR because of reaching API limit. It makes sense to wait for some time and try again later.

@0x4007
Copy link
Member

0x4007 commented Jun 18, 2024

Doesn't look right, unless you re-ran manually!

c124c0a
c124c0a
c124c0a
c124c0a

@rndquu
Copy link
Member

rndquu commented Jun 18, 2024

@EresDev Now we need to merge the latest development to the beta branch so that a new project beta-pay-ubq-fi is created in cloudflare dashboard, right?

@EresDev
Copy link
Contributor Author

EresDev commented Jun 18, 2024

Doesn't look right, unless you re-ran manually!

c124c0a
c124c0a
c124c0a
c124c0a

I am unable to see what is wrong in these links. If you are expecting to see gift card on the above URL, the commit belongs to development branch and development branch doesn't have gift cards yet.

Or, you are probably referring to API limit, then yes re-running it manually worked.

@EresDev
Copy link
Contributor Author

EresDev commented Jun 18, 2024

@EresDev Now we need to merge the latest development to the beta branch so that a new project beta-pay-ubq-fi is created in cloudflare dashboard, right?

beta branch has already what we have added a few hours ago to development for deployment. No need to merge.
The cloudflare deploy action creates a new project by repository name, not branch name. Cloudflare will only create a new project if there is not an existing project with given repository name. Because there is already a project pay.ubq.fi on cloudflare, it will not create a new project, and will just use the existing one.
I didn't change anything related to the creation of new project in the deploy workflow. The process is the same as it was before the gift card.

If the "deploy to cloudflare" workflow was successful, you can see in its logs if a new project was created in the cloudflare or an existing one was used.

@0x4007
Copy link
Member

0x4007 commented Jun 19, 2024

Currently asking @Steveantor to delete their usage of the namespace.

Otherwise we are currently using pay-ubq-fi-bxp.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants