Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add yarn.lock #233

Merged
merged 1 commit into from
May 31, 2024
Merged

build: add yarn.lock #233

merged 1 commit into from
May 31, 2024

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented May 31, 2024

No description provided.

@rndquu
Copy link
Member Author

rndquu commented May 31, 2024

@Keyrxng Do you remember why was yarn.lock removed from the repo? I have to create it from scratch every time on QAing PRs.

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented May 31, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 31, 2024 •
edited
Loading

Preview Deployment
1fd6a3fecf1bec512c17c156649662719ef78cec
c87543d65244e3a5fd35c506fd8fd81b9b2f4c8e

@rndquu rndquu marked this pull request as ready for review May 31, 2024 07:46
@Keyrxng
Copy link
Member

Keyrxng commented May 31, 2024

For no particular reason that it cannot be added back as far as I'm aware

  • efff1d7 appears to be when it was removed and I'm assuming it was to make the PR cleaner although I've just avoided committing it since and for the same reason pretty much

@rndquu
Copy link
Member Author

rndquu commented May 31, 2024

@gentlementlegen Was yarn.lock removed for a particular reason at efff1d7 ?

@gentlementlegen
Copy link
Member

@rndquu no, this project doesn't use bun so no reason to be deleted. Strange that we didn't spot it, apologies.

@rndquu rndquu merged commit c87543d into ubiquity:development May 31, 2024
4 checks passed
@rndquu rndquu deleted the build/yarn-lock branch May 31, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rndquu @Keyrxng @gentlementlegen