Mobile: Claim URL handling

[Keyrxng]

The claim string can break the app on mobile when eth_requestAccounts is called and if a user is required to give the app permission.

The URL must be shortened and the permit must still be valid. Either process the data before the call or store the string and process it after.

time < 2 hr

---

I was unable to actually connect, I could select select all and add account or hardware wallet but couldn't hit the buttons below those needed to actually connect.

I stuck a random connectWallet() in init.ts and visited / to get around it.

Reproduce by clearing all browsing data from MM mobile browser and then heading to a valid permit url.

[0x4007]

I've never seen this before. We would need to use a new encoding scheme, none of which come to mind as a quick solution. Are you suggesting to remove the query string right before the RPC method is called? If so, that should only be a line of code, right?

Insane to me how bad Metamask mobile is.

[Keyrxng]

@0x4007 I was thinking more just media query and detect mobile before the eth_requestAccounts call store the permit string locally and then clear the url param with window.history or similar, fire the call and afterwards replace it the same way it was removed.

afaik this doesn't require any page reloads so it should work and already have bypassed the no claim data found in url check.

[ubiquibot]

! No price label has been set. Skipping permit generation.

[ubiquity-os-main]

! No price label has been set. Skipping permit generation.

[ubiquibot]

+ Evaluating results. Please wait...

[ubiquibot]

[ 5.9 WXDAI ]

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	5.9

Conversation Incentives

Comment	Formatting	Relevance	Reward
I've never seen this before. We would need to use a new encoding...	5.9	0.79	5.9

[ 195.8 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	30.2
Issue	Task	1	150
Issue	Comment	1	15.6
Issue	Comment	1	0

Conversation Incentives

Comment	Formatting	Relevance	Reward
The `claim` string can break the app on mobile when `...	30.2 code: count: 7 score: "7" words: 12	1	30.2
@0x4007 I was thinking more just media query and detect mobile b...	15.6 code: count: 2 score: "2" words: 7	0.86	15.6
@0x4007 I was thinking more just media query and detect mobile b...	- code: count: 2 score: "0" words: 7	0.86	-

[ubiquity-os-main]

[ 6.408 WXDAI ]

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	4.408
Review	Comment	1	2

Conversation Incentives

Comment	Formatting	Relevance	Reward
I've never seen this before. We would need to use a new encoding…	5.8 content: p: count: 58 score: 1 wordValue: 0.1 formattingMultiplier: 1	0.76	4.408
Simple enough of a fix. I hope that you tested this thoroughly t…	2.5 content: p: count: 25 score: 1 wordValue: 0.1 formattingMultiplier: 1	0.8	2

[ 173.846 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	150
Issue	Specification	1	10.56
Issue	Comment	1	13.286
Review	Comment	1	0

Conversation Incentives

Comment	Formatting	Relevance	Reward
The `claim` string can break the app on mobile when `…	12.8 content: p: count: 116 score: 1 code: count: 12 score: 1 img: count: 1 score: 0 wordValue: 0.1 formattingMultiplier: 1	0.825	10.56
@0x4007 I was thinking more just media query and detect mobile b…	14.6 content: p: count: 66 score: 1 code: count: 7 score: 1 wordValue: 0.2 formattingMultiplier: 1	0.91	13.286
Resolves #243 You were right @0x4007 and I was over thinking it…	0 content: p: count: 29 score: 1 code: count: 1 score: 1 wordValue: 0 formattingMultiplier: 0	0.675	-

[Keyrxng]

@0x4007 it looks like the funding wallet needs funded

[0x4007]

I need to process payroll asap. It's especially tedious at this moment because I need to work with the multisig to top up the hot wallet. Will prioritize this.

[Keyrxng]

I need to process payroll asap. It's especially tedious at this moment because I need to work with the multisig to top up the hot wallet. Will prioritize this.

Do you have a rough ETA on this @0x4007?

[0x4007]

I need to process payroll asap. It's especially tedious at this moment because I need to work with the multisig to top up the hot wallet. Will prioritize this.

Do you have a rough ETA on this @0x4007?

Try now