Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear url param after load #245

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

Keyrxng
Copy link
Member

@Keyrxng Keyrxng commented Jun 10, 2024

Resolves #243

You were right @0x4007 and I was over thinking it. We've already passed the url check and built the appState so this looks to resolve things.

claimurl.MP4

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Jun 10, 2024

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough of a fix. I hope that you tested this thoroughly to ensure that you can switch permit claims and everything works as expected.

@0x4007 0x4007 merged commit 23460da into ubiquity:development Jun 11, 2024
4 checks passed
Copy link
Contributor

Preview Deployment
23460dabf8b17ed76ed86e34af8b5c4bade51ba2

@Keyrxng
Copy link
Member Author

Keyrxng commented Jun 11, 2024

Simple enough of a fix. I hope that you tested this thoroughly to ensure that you can switch permit claims and everything works as expected.

That's why I over-thought it at first, off the top of my head I thought there would be a requirement somewhere that we'd need the string again but there is no resetting of AppState after the initial load. So long as the permits are decoded properly everything should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Claim URL handling
2 participants