Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self dispatched workflow functions #20

Open
Keyrxng opened this issue Oct 29, 2024 · 0 comments
Open

Self dispatched workflow functions #20

Keyrxng opened this issue Oct 29, 2024 · 0 comments

Comments

@Keyrxng
Copy link
Collaborator

Keyrxng commented Oct 29, 2024

Now that the kernel' APP_ID and APP_PRIVATE_KEY have been exposed as org secrets I think I should go back to my original implementation where the worker for this plugin controlled the dispatching of it's own workflows for MTProto API (workrooms, etc...) features.

  • with two config entries ubiquity-os kernel is dispatching tons of workflows for no reason which can be avoided
  • self-dispatched means we can validate no-op payloads first
  • it's cleaner and more efficient from a plugin standpoint
  • removes the need for two entries in the config
  • optimizes the github rate limit consumed by this plugin
  • it's no longer considered "unsafe" to do so or the secrets wouldn't be exposed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant