Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow Issue Matching across org/repos #61

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

sshivaditya2019
Copy link
Collaborator

Resolves #60

  • Allows Issue Matching outside repos and orgs.
  • New pg func for handling the issue matching

@sshivaditya2019
Copy link
Collaborator Author

@@ -91,10 +91,14 @@ export async function issueMatching(context: Context<"issues.opened" | "issues.e
return null;
}
});
const issueList = (await Promise.all(fetchPromises)).filter((issue) => issue !== null);
const issueList = await Promise.allSettled(fetchPromises);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this error prone if a single request fails then everything fails?

@@ -141,7 +141,7 @@ redirect_uri = ""
url = ""

[analytics]
enabled = true
enabled = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no analytics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue Matching Fails, with invalid payload object.
3 participants