Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always Recommend Contributors #54

Merged

Conversation

sshivaditya2019
Copy link
Collaborator

Resolves #45

  1. The DB gets populated by handling issue complete webhook
  2. alwaysRecommends the specified number of contributors if not specified config works as usual.

@0x4007
Copy link
Member

0x4007 commented Nov 30, 2024

QA?

@sshivaditya2019
Copy link
Collaborator Author

@0x4007
Copy link
Member

0x4007 commented Nov 30, 2024

Why does it only work after you close it? It's supposed to be immediate after the issue is opened or edited.

@sshivaditya2019
Copy link
Collaborator Author

Why does it only work after you close it? It's supposed to be immediate after the issue is opened or edited.

In the QA examples, all of them had similarity more than 90%. Otherwise, it would work when edited and labeled

Example warningThreshold

@0x4007
Copy link
Member

0x4007 commented Dec 1, 2024

Why does it only work after you close it? It's supposed to be immediate after the issue is opened or edited.

In the QA examples, all of them had similarity more than 90%. Otherwise, it would work when edited and labeled

Example warningThreshold

Sorry but this doesn't make any sense to me. It doesn't matter what the similarity level is, it should always recommend talent, as per the title of the task.

@sshivaditya2019
Copy link
Collaborator Author

sshivaditya2019 commented Dec 1, 2024

Example warningThreshold

Sorry but this doesn't make any sense to me. It doesn't matter what the similarity level is, it should always recommend talent, as per the title of the task.

Yeah it does always recommend talent based on title, when edited/opened/labeled, regardless of the similarity value with the alwaysRecommended flag.

So, it works even when the issue is not closed, which you can see by the second example.

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA seems fine

@0x4007 0x4007 merged commit 2d5169f into ubiquity-os-marketplace:development Dec 3, 2024
2 checks passed
@ubiquity-os-beta ubiquity-os-beta bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always Recommend Talent
3 participants