fix: change to draft only on changes requested #65
Conversation
…ly-review-request
…nto fix/draft-only-review-request
| message.push( | ||
| `- Assignees will be disqualified after \`${formatMillisecondsToDaysAndHours(context.config.disqualification / priorityValue)}\` of inactivity.` | ||
| `- Assignees will be disqualified after \`${formatMillisecondsToHumanReadable(context.config.disqualification / priorityValue)}\` of inactivity.` |
There was a problem hiding this comment.
It will be considered as 1 for deadlines, is that ok?
Example with 0 prio: Meniole#7 (comment)
There was a problem hiding this comment.
That or infinity. Let's try 1 for now then. I'm just considering the ability to set float levels like priority 0.5 and the system acting predictably. So 0 should predictably be infinity but it's also sort of rarely used so we'll see.
There was a problem hiding this comment.
Even when the priority is 0 we still want the disqualifier to run right? If so I don't think infinity makes sense, it should use the same timers as a priority 1.
| @@ -34,6 +34,7 @@ const query = /* GraphQL */ ` | |||
| id: databaseId | |||
| } | |||
| } | |||
| reviewDecision | |||
There was a problem hiding this comment.
I guess this is based on the last review?
There was a problem hiding this comment.
According to the docs it contains the last global state of the review: https://docs.github.com/en/graphql/reference/enums#pullrequestreviewdecision
Relates to #59 (comment)
Resolves #64
We turn the PR to draft only if changes were requested.