Fix issues #22

Keyrxng · 2024-09-15T18:10:20Z

Resolves #21

Below is the activity logged after lastCheck.

old results from 110

[
  {
    event: 'review_requested',
    created_at: '2024-09-15T00:21:13Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'review_requested',
    created_at: '2024-09-14T05:58:45Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'review_requested',
    created_at: '2024-09-14T05:58:44Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'review_requested',
    created_at: '2024-09-14T05:58:44Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'ready_for_review',
    created_at: '2024-09-14T05:57:21Z',
    actor: 'gentlementlegen'
  }
]

new results:

[
  {
    event: 'review_requested',
    created_at: '2024-09-15T00:21:13Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'committed',
    created_at: '2024-09-15T00:16:33Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'review_requested',
    created_at: '2024-09-14T05:58:45Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'review_requested',
    created_at: '2024-09-14T05:58:44Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'review_requested',
    created_at: '2024-09-14T05:58:44Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'ready_for_review',
    created_at: '2024-09-14T05:57:21Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'committed',
    created_at: '2024-09-14T05:55:14Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'committed',
    created_at: '2024-09-14T05:50:43Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'committed',
    created_at: '2024-09-14T05:20:33Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'committed',
    created_at: '2024-09-13T20:57:37Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'committed',
    created_at: '2024-09-13T20:48:44Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'committed',
    created_at: '2024-09-13T19:04:53Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'committed',
    created_at: '2024-09-13T16:35:06Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'committed',
    created_at: '2024-09-13T16:12:54Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'committed',
    created_at: '2024-09-13T16:11:02Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'committed',
    created_at: '2024-09-13T16:06:00Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'committed',
    created_at: '2024-09-13T16:00:00Z',
    actor: 'gentlementlegen'
  },
  {
    event: 'committed',
    created_at: '2024-09-13T15:53:56Z',
    actor: 'gentlementlegen'
  }
]

github-actions · 2024-09-15T18:11:15Z

Unused types (1)

Filename	types
src/types/github-types.ts	`ListCommentsForIssue`

src/helpers/get-assignee-activity.ts

src/helpers/task-deadline.ts

src/types/plugin-inputs.ts

Co-authored-by: Mentlegen <[email protected]>

gentlementlegen

Could you please update README.md since I think the configuration changed?

src/types/plugin-inputs.ts

Keyrxng · 2024-09-19T10:58:42Z

@gentlementlegen tests added and issue resolved

gentlementlegen · 2024-09-19T15:14:51Z

The configuration is fixed, but I am a bit lost with the current behavior of that plugin after testing it. I do not know if that is introduced by the changes of this pull-request, but look at this run:

I just started a task by assigning myself
the deadline according to the logs is in the past
I get unassigned right away

Keyrxng · 2024-09-19T15:46:59Z

So because you used the /start command last month, then just now assigned via UI self-assign, it has taken the deadline from the what I assume is the comment as opposed to your self-assignment event.

{
  "now": "Sep 19, 2024, 3:09 PM",
  "reminder": "Aug 22, 2024, 9:37 AM",
  "deadline": "Aug 22, 2024, 9:38 AM",
  "caller": "updateTaskReminder"
}

So what's the solution? Fix the .sort() usage.

Do we as an org permit contributors to self-assign? It bypasses checks in other plugins.

Keyrxng · 2024-09-19T16:46:01Z

Likely myself who introduced it @gentlementlegen. Realized sort was backwards, but your example highlighted the fact we should use the timeline over comments if the timeline is later than the lastCheck so I implemented that and updated tests

gentlementlegen · 2024-09-20T03:15:14Z

@Keyrxng I pulled your latest changes and ran again, the behavior was similar

Do we as an org permit contributors to self-assign? It bypasses checks in other plugins.

This applies only to members but we could potentially be un-assigned for no reason the way it is happening to me right now. Can't we only based the checks to use the timeline events and check the last time a user was assigned?

Related run: https://github.com/Meniole/user-activity-watcher/actions/runs/10952491105/job/30411260264#step:5:31

0x4007 · 2024-09-21T07:45:49Z

Ignore the deadline.

Unassignment only should happen after 7 days of no activity (configurable)

0x4007 · 2024-09-21T07:48:18Z

README.md

@@ -43,4 +43,9 @@ yarn test
      optOut:
        - "repoName"
        - "repoName2"
+    eventWhitelist: # these are the tail of the webhook event i.e pull_request.review_requested


Should just use the full identifier. Shortening just will lead to confusion.

So the config would take the full pull_request.review_requested and I'll handle string splitting, is that what you mean?

It doesn't look like this was ever updated in the readme.

Looks like this was never fixed. Should use full webhook names.

daemon-disqualifier/tests/main.test.ts

Line 67 in 9ca3f7b

it("Should correctly transform the eventWhitelist", () => {

Keyrxng · 2024-09-24T14:40:07Z

QA: https://github.com/ubq-testing/user-activity-watcher/actions/runs/11016118749/job/30590832730

Can't we only based the checks to use the timeline events and check the last time a user was assigned?

I got rid of the lastCheck and any comment related logic. So we just use the start event and timeline activity.

0x4007

It's not clear to me if you're ignoring the deadline as I requested, and if you are actually checking the assign event on the timeline, instead of checking the metadata from the /start response.

src/helpers/task-update.ts

DeFi-crypto · 2024-09-26T23:56:14Z

This looks really interesting. I'm trying to try the plugin currently and it seems to be working fine.

0x4007 · 2024-10-08T08:29:06Z

src/types/plugin-inputs.ts

+            ["review_requested", "pull_request.review_requested"],
+            ["ready_for_review", "pull_request.ready_for_review"],
+            ["commented", "pull_request_review_comment.created"],
+            ["commented", "issue_comment.created"],
+            ["committed", "push"],


Are these defaults?

0x4007 · 2024-10-08T08:30:28Z

README.md

@@ -43,4 +43,9 @@ yarn test
      optOut:
        - "repoName"
        - "repoName2"
+    eventWhitelist: # these are the tail of the webhook event i.e pull_request.review_requested


It doesn't look like this was ever updated in the readme.

0x4007 · 2024-10-10T08:04:48Z

src/helpers/task-metadata.ts

+  metadata.startPlusLabelDuration =
+    DateTime.fromISO(mostRecentAssignmentEvent?.created_at || issue.created_at)
+      .plus({ milliseconds: durationInMs })
+      .toISO() || "";


Setting the duration to an empty string looks wrong.

0x4007

Can address remaining problems later. The plugin is quite dysfunctional in production and I think this will get most of the essential functionality back up.

Unfortunately due to merge conflicts this won't be able to be merged.

Keyrxng added 5 commits September 15, 2024 15:44

debug: temp

046c843

refactor: listEventsForTimeline

a857dbb

chore: update tests

f0e0aa5

chore: timestamp log

500d0de

chore: fix sort

bdf9347

chore: knip

6157287

Keyrxng requested review from gentlementlegen and 0x4007 September 15, 2024 18:15

chore: any commit counts

9196ec8

0x4007 reviewed Sep 15, 2024

View reviewed changes

src/helpers/get-assignee-activity.ts Outdated Show resolved Hide resolved

src/helpers/task-deadline.ts Outdated Show resolved Hide resolved

chore: refactor null checks

4c6156c

gentlementlegen reviewed Sep 18, 2024

View reviewed changes

src/types/plugin-inputs.ts Outdated Show resolved Hide resolved

Keyrxng and others added 3 commits September 19, 2024 08:48

Update src/types/plugin-inputs.ts

79a9906

Co-authored-by: Mentlegen <[email protected]>

chore: remove curly boi

005cfff

chore: cspell, prettier

61bc900

gentlementlegen reviewed Sep 19, 2024

View reviewed changes

chore: update readme

863ea9a

gentlementlegen reviewed Sep 19, 2024

View reviewed changes

src/types/plugin-inputs.ts Outdated Show resolved Hide resolved

chore: add default config tests

960a7bf

chore: fix tests, using timeline over comment if later than

e05524d

chore: replace return false, removed during debug

1dc9c33

0x4007 requested changes Sep 21, 2024

View reviewed changes

chore: use only the timeline events

68a3b58

Keyrxng added 3 commits September 24, 2024 14:59

chore: use full webhook event for config

6a2d826

chore: new config tests

a48cdcc

chore: knip

9ca3f7b

0x4007 requested changes Sep 25, 2024

View reviewed changes

src/helpers/task-update.ts Show resolved Hide resolved

Keyrxng mentioned this pull request Sep 26, 2024

Hide unauthorized issues ubiquity/work.ubq.fi#84

Closed

0x4007 reviewed Oct 8, 2024

View reviewed changes

0x4007 reviewed Oct 10, 2024

View reviewed changes

0x4007 mentioned this pull request Oct 10, 2024

Use Full Webhook Names #29

Closed

0x4007 approved these changes Oct 10, 2024

View reviewed changes

0x4007 mentioned this pull request Oct 10, 2024

fix: #21 #30

Merged

0x4007 closed this in #30 Oct 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issues #22

Fix issues #22

Keyrxng commented Sep 15, 2024

github-actions bot commented Sep 15, 2024 •

edited

Loading

gentlementlegen left a comment

Keyrxng commented Sep 19, 2024

gentlementlegen commented Sep 19, 2024

Keyrxng commented Sep 19, 2024 •

edited

Loading

Keyrxng commented Sep 19, 2024

gentlementlegen commented Sep 20, 2024 •

edited

Loading

0x4007 commented Sep 21, 2024

0x4007 Sep 21, 2024

Keyrxng Sep 21, 2024

0x4007 Oct 8, 2024

0x4007 Oct 10, 2024

Keyrxng commented Sep 24, 2024 •

edited

Loading

0x4007 left a comment

DeFi-crypto commented Sep 26, 2024

0x4007 Oct 8, 2024

0x4007 Oct 8, 2024

0x4007 Oct 10, 2024

0x4007 left a comment •

edited

Loading

Fix issues #22

Fix issues #22

Conversation

Keyrxng commented Sep 15, 2024

github-actions bot commented Sep 15, 2024 • edited Loading

Unused types (1)

gentlementlegen left a comment

Choose a reason for hiding this comment

Keyrxng commented Sep 19, 2024

gentlementlegen commented Sep 19, 2024

Keyrxng commented Sep 19, 2024 • edited Loading

Keyrxng commented Sep 19, 2024

gentlementlegen commented Sep 20, 2024 • edited Loading

0x4007 commented Sep 21, 2024

0x4007 Sep 21, 2024

Choose a reason for hiding this comment

Keyrxng Sep 21, 2024

Choose a reason for hiding this comment

0x4007 Oct 8, 2024

Choose a reason for hiding this comment

0x4007 Oct 10, 2024

Choose a reason for hiding this comment

Keyrxng commented Sep 24, 2024 • edited Loading

0x4007 left a comment

Choose a reason for hiding this comment

DeFi-crypto commented Sep 26, 2024

0x4007 Oct 8, 2024

Choose a reason for hiding this comment

0x4007 Oct 8, 2024

Choose a reason for hiding this comment

0x4007 Oct 10, 2024

Choose a reason for hiding this comment

0x4007 left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Sep 15, 2024 •

edited

Loading

Keyrxng commented Sep 19, 2024 •

edited

Loading

gentlementlegen commented Sep 20, 2024 •

edited

Loading

Keyrxng commented Sep 24, 2024 •

edited

Loading

0x4007 left a comment •

edited

Loading