Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only draft the pull-request if a review was requested #64

Open
gentlementlegen opened this issue Dec 12, 2024 · 4 comments · May be fixed by #65
Open

Only draft the pull-request if a review was requested #64

gentlementlegen opened this issue Dec 12, 2024 · 4 comments · May be fixed by #65
Assignees

Comments

@gentlementlegen
Copy link
Member

gentlementlegen commented Dec 12, 2024

          All right then I will proceed with the following changes on the pull-request:
  • the PR will be converted to draft only if there are reviews in "changes requested" state
  • otherwise, only the reminder will be posted and no state change will occur on the pull-request

Sounds good?

Originally posted by @gentlementlegen in #59 (comment)

Instead of always converting the PR to a draft, it should only happen if changes were requested by reviewers.1

Footnotes

  1. ⚠ 51% possible duplicate - Pull Request State Adjustments

@gentlementlegen gentlementlegen self-assigned this Dec 12, 2024
Copy link

! Error: Error: No labels are set.

Copy link

Important

  • Be sure to link a pull-request before the first reminder to avoid disqualification.
  • Reminders will be sent every 7 days if there is no activity.
  • Assignees will be disqualified after 14 days of inactivity.

@0x4007
Copy link
Member

0x4007 commented Dec 12, 2024

! Error: Error: No labels are set.

I'm not sure why or how these slip in only after passing QA but obviously we need to fix

@gentlementlegen
Copy link
Member Author

Probably when switched from the plugin posting the the SDK actually posting, this is considered as a thrown error and gets posted, so I believe this function should not throw.

@gentlementlegen gentlementlegen linked a pull request Dec 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants