Command ask

[ishowvel]

Resolves #45

[ishowvel]

@gentlementlegen to test this you would have to change the config and specify a anthropic model in anthropicAiModel and rename the existing model to openAiModel

[ishowvel]

heres the qa
ishowvel-org/.ubiquity-os#52
ishowvel-org/.ubiquity-os#49

[0x4007]

The QA doesn't show it working. Also this should be its own plugin.

[ishowvel]

The QA doesn't show it working. Also this should be its own plugin.

@0x4007 I thought showing the edge cases of when Claude gives a non json output, when review passes, when review fails was enough, is there any thing else I need to do to qa this

I'll turn this into a standalone plugin in a bit

[0x4007]

The QA doesn't show it working. Also this should be its own plugin.

@0x4007 I thought showing the edge cases of when Claude gives a non json output, when review passes, when review fails was enough, is there any thing else I need to do to qa this

No please read the spec carefully

The bot should return actionable feedback for what is missing from the specification. It should leave the review state as requested changes. It should also convert the pull back into a draft.

[ishowvel]

Only converting this to a standalone plugin is left

[ishowvel]

https://github.com/ishowvel/pull-precheck
standalone plugin has been made, ill make fresh tests tomorrow

[ishowvel]

@gentlementlegen can i have a little help over here?
https://github.com/ishowvel/pull-precheck/blob/development/tests/main.test.ts
somehow mocking a function from a different file just does not seem to work, any idea on how to fix this or what i am doing wrong

[ishowvel]

i have tested the standalone plugin and everything works, i am just having a little difficulty setting up tests

[gentlementlegen]

With ESM import order is very important and will define what / how modules are mocked. You should check the function is actually called, and if it is not your mocked function then you should figure out which import overrides your own mock by being called before you actually do mock the function.

[0x4007]

This isn't a new plugin. This is ask with added features. Ask code shouldn't be here at all.