Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test-utils): BrowserTestDriver injected function types #254

Merged
merged 1 commit into from
Apr 8, 2024
+2 −2
Merged

fix(test-utils): BrowserTestDriver injected function types #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/test-utils/src/browser-automation/browser-test-driver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@

declare global {
function browserTestDriver_fail(): void;
function browserTestDriver_finish(): string;
function browserTestDriver_emulateInput(event: unknown): void;
function browserTestDriver_finish(message?: string): void;
function browserTestDriver_emulateInput(event: unknown): Promise<void>;
function browserTestDriver_captureAndDiffScreen(opts: DiffImagesOpts): Promise<DiffImageResult>;
}

Expand Down Expand Up @@ -100,7 +100,7 @@

return this.startBrowser(browserConfig).then(
_ =>
new Promise<string>(async (resolve, reject) => {

Check warning on line 103 in modules/test-utils/src/browser-automation/browser-test-driver.ts

View workflow job for this annotation

GitHub Actions / test (18) 

Promise returned in function argument where a void return was expected

Check warning on line 103 in modules/test-utils/src/browser-automation/browser-test-driver.ts

View workflow job for this annotation

GitHub Actions / test (20) 

Promise returned in function argument where a void return was expected
const exposeFunctions = {
...config.exposeFunctions,
browserTestDriver_fail: () => this.failures++,
Expand Down
Loading