Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test-utils): add onStart/onFinish callbacks to BrowserTestDriver #248

Merged
merged 2 commits into from
Feb 19, 2024
Merged

feat(test-utils): add onStart/onFinish callbacks to BrowserTestDriver #248

merged 2 commits into from
Feb 19, 2024

Conversation

Pessimistress
Copy link
Collaborator

  • Add onStart/onFinish callbacks to BrowserTestDriver
  • Add coverage report to vite example

ibgreen
ibgreen approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just nits/suggestions.

As a side, I recall trying to move this probe.gl module to ocular a couple of times but I think there was something with different build setup that made it non-trivial

docs/modules/test-utils/browser-test-driver.md Show resolved Hide resolved
examples/browser-test-vite/package.json Outdated Show resolved Hide resolved
modules/test-utils/src/browser-automation/browser-test-driver.ts Outdated Show resolved Hide resolved
examples/browser-test-vite/test/start.js Outdated Show resolved Hide resolved
modules/test-utils/src/browser-automation/browser-driver.ts Show resolved Hide resolved
modules/test-utils/src/browser-automation/browser-test-driver.ts Outdated Show resolved Hide resolved
@Pessimistress Pessimistress merged commit 8c1e1c2 into master Feb 19, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/coverage-callbacks branch February 19, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pessimistress @ibgreen