Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename log.priority to log.level #114

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Rename log.priority to log.level #114

merged 2 commits into from
Dec 5, 2019

Conversation

Pessimistress
Copy link
Collaborator

Follow up of discussion on visgl/deck.gl#3957 (comment)

No breaking change - priority is still supported.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 41.311% when pulling 46ee160 on x/log-level into da424b0 on master.

ibgreen
ibgreen approved these changes Dec 5, 2019
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@Pessimistress Pessimistress merged commit 4bd5096 into master Dec 5, 2019
Pessimistress added a commit that referenced this pull request Dec 16, 2019
@Pessimistress
Rename log.priority to log.level (#114)
6418864
@ibgreen ibgreen deleted the x/log-level branch December 26, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

@tsherif tsherif Awaiting requested review from tsherif

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @ibgreen