Move CDN CLF libraries to hook_library_info_build()

[joelpittet]

This is a clean-up thing because the libraries file was getting long and there is lots of duplication happening in there.

I have not tested that this works... yet. So this is more of a drive by Proof of Concept. Needs a quick test and review before merging

[joelpittet]

Ok I tested it and it seems to work. Now the question is if this is valuable @occupant? My motivation was to shrink the libraries file down.

[occupant]

@joelpittet Nice. I like this, but I wonder if "hiding" the libraries in a theme hook is easier or harder to manage? The "advantage" to having them in the libraries file is they are all in one place and use the same method of addition. I'm sure the method of adding the library is the same under the hood regardless of which approach is used (hook vs libraries file), so it's more a question of having one approach / place to manage vs two. That said, I think it's entirely appropriate that they get moved, if for no other reason than these libraries are not intended to be easily editable.

It drives me a little bonkers that these CSS files exist as separate items - this is a perfect example of where css variables would be perfect. One file and a small selection of variables could easily handle this much more efficiently. Oh well, one can dream.

So, my feeling is it's worth changing (and you obviously feel the same :) ) so let's make the update. It looks like hook_page_attachments_alter will just work the same.

[occupant]

All looks good to go!

[joelpittet]

I am hesitant because I agree with you that it's moving out of a common place people look to a more "advanced" method of adding libraries. The only reason was there was so much duplication in that yaml file it was annoying to scroll past, but not sure if that is reason enough to move it out. Also because it's in a loop now if you want to make config changes you can do it to all them in one big move... so on the fence with you :)