Flyout #60
Open
Flyout #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add sticky option related changes * apply debouncing scroll events
* add dependecies for postcss and autoprefixer * Tweak npm script to work without npx on the end CSS
…es#51) * Develop (ubc-web-services#49) * Fix whitespace in theme-settings.php * Fix whitespace in template.php * Fix for class generation in ubc-web-services#33 * Initial commit * Add Drawer region; Drawer is now working * Add sticky navigation option; sticky option is now working * Control loading JS, CSS files when drawer option is disabled/enabled * Rename drawer button; fix conditionals on page.tpl.php * Remove inactive options * Give default value to clf_navigation_placement * Use Drupal behaviors to JS * Fix namespace conflict * Fix overflow issue; add drawer slide-in trigger to hamburger button * Replaced the rendered $drawer_nav template variable with the new drawer region rendering. But the contents of $drawer_nav into a renderable array instead of the rendered string and stored it in the region. Replaced $containerstart/$containerend with a div and added attributes to it instead of possible duplicate wrapper divs since we are adding a new one anyways. * Make the region printing the primary menu optional * Change arrow direction&color; adjust arrow theme in drawer region * Remove unnecessary important keywords & in-line styles; * Add BEM class; adjust line-height of drawer button * remove unncessary params & args in js file * move adding sticky option to a separate PR * remove sticky option related CSS/JS files * make the labels clearer * replace navigation_placement to drawer_region * add less source file * adjust wording on theme appearance form
…primary nav is a good idea if choosing not to use the primary nav in the drawer, otherwise primary nav goes away entirely
…ter in the clf_navigation_option section
…ve right on sticky mobile
…s by creating a separate containing div for the flyout
… where secondary menu was not expanding on click
…es not poke through visually
…e drawer nav when taller than viewport
… needs to be 100% for scrolling
…g under it on mobile
… obfuscates content. This should be done dynamically on click.
…d overrides it in a child theme and it should be there in megatron
|
Cool, James.
The flyout branch is rather old at this point and a ton has been added in
our child themes to make it all work. Not sure of the ROI of wedging this
into a theme that few people will use going forward. I had a chance to
deploy your D8 Galactus theme on a D7 upgrade attempt and I'll eventually
need to add the flyout to that theme so it might make sense to wait until
then?
Perhaps a quick chat this week? We have free coffee :-)
…On Mon, Jun 17, 2019 at 9:59 PM James ***@***.***> wrote:
Hi Darko, I'm finally getting back to Megatron (had a bug I had to fix),
so I should get this in there too :)
Just wondering about the 3 pull requests - this one includes #58
<#58> and #59
<#59>, is that correct?
Let me know and I'll go through everything here and we can get it into
place.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#60?email_source=notifications&email_token=AAM3ZLMB47SZDXXX7PKKDFTP3BTSBA5CNFSM4FHJBGF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX5F3KA#issuecomment-502947240>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAM3ZLO6DK74FG27ANKMMA3P3BTSBANCNFSM4FHJBGFQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flyout button z-index lower than mobile menus
Main menu items with no children need bg color so flyout button doesn't poke through
Moved flyout button out of nav structure in page.tpl.php so z-index on menu works
Other improvements/fixes to make it work with our flyout needs