-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package vulnerability audit dec 2024 #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the primary process in a container, through taking over execution of the entrypoint script via a command; Increased python-multipart pacakge version to avoid vulnerability; increased eslint's version to remove dependency which has vulnerability; this required upgrading the eslint configuration within rosalution to use the new flat file configuration. It is temporarily tuned to be close to the existing code base linting however, the team will review and revise linting guidelines when we gather soon.
…stigating, in order to avoid the vulnerabily also being inside the docker images, need to upgrade to both alpine3.21 & 23.4.; Linting upgrade for eslint to 9.16 for system tests & some updates to corresponding tests.
….json to indicate its of type module for JavaScript.
…encies that have vulnerabilities
fatimarabab
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Pull Request Details
Wrike Ticket - Issue Title
Changes made:
Upgrading package dependencies to avoid the following vulnerabilities:
To Review:
Static Analysis by Reviewer
Packages have updated versions and for packages that couldn't upgrade away from the vulnerability, are forced to resolve to the fixed package.
To check this run the following commands:
./setup.sh clean cd frontend yarn audit yarn test:coverage yarn lint
./setup.sh clean cd system-tests yarn audit
The changes made to micro service dependencies are working as intended/rendered correctly.
To check this run the following commands:
Visit any analysis and attach a file with the '.gb' file extension.
All Github Actions checks have passed.