-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New annotations from opencravat #188
Merged
SeriousHorncat
merged 10 commits into
rosalution-0.8.1-patch
from
new-annotations-from-opencravat
Dec 11, 2024
Merged
New annotations from opencravat #188
SeriousHorncat
merged 10 commits into
rosalution-0.8.1-patch
from
new-annotations-from-opencravat
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that row be horizontal
…h not visualizing yet. Some additional linkout datasets included also.
fatimarabab
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
10 tasks
SeriousHorncat
added a commit
that referenced
this pull request
Dec 11, 2024
* Rendering some of the new linkouts and datasets, with some fixture updates * Fixed linting and added gnomad to be added as annotations; even though not visualizing yet. Some additional linkout datasets included also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Pull Request Details
Wrike Ticket - Feature-Updated Annotations from OpenCravat
Changes made:
To Review:
Static Analysis by Reviewer
The changes made for the new annotations configured and that they are rendering and are working as intended/rendered correctly.
To check this run the following commands:
# From the project root docker compose down docker system prune -a --volumes docker compose up --build
CILI_2_5K_ARMC9_L510V.json
frometc/fixtures/import
and verify the new annotations are rendering.All Github Actions checks have passed.