Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New annotations from opencravat #188

Merged
merged 10 commits into from
Dec 11, 2024

Conversation

SeriousHorncat
Copy link
Collaborator

@SeriousHorncat SeriousHorncat commented Dec 11, 2024

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines enforced by static analysis tools.
  • If it is a core feature, I have added thorough tests.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Will this be part of a product update? If yes, please write one phrase about this update.

Pull Request Details

Wrike Ticket - Feature-Updated Annotations from OpenCravat

Changes made:

  • Increased the delay for annotation not being ready, due to many more annotations being added and needing more time for tasks to be on the queue.
  • Dataset that creates a version of the hgvs cdna variant that doesn't include the transcript version so that it can be used to query Ensembl's REST API for VEP
  • New Linkout Datsets for GnomAD4 Variant, COSMIC
  • Rendering REVEL and AlphaMissense for variants now
  • Updated a row to render datasets horizontal if the associated class is included in the rendering configuration. Variant annotations were rendering vertically and it was taking too much space.

To Review:

  • Static Analysis by Reviewer

  • The changes made for the new annotations configured and that they are rendering and are working as intended/rendered correctly.

    To check this run the following commands:

    # From the project root
    docker compose down
    docker system prune -a --volumes
    
    docker compose up --build
    • Verify CPAM0002 has AlphaMissense annotations rendering (other variants don't have scores in the fixtures)
    • Import example analysis CILI_2_5K_ARMC9_L510V.json from etc/fixtures/import and verify the new annotations are rendering.

    image

  • All Github Actions checks have passed.

@SeriousHorncat SeriousHorncat self-assigned this Dec 11, 2024
@SeriousHorncat SeriousHorncat marked this pull request as ready for review December 11, 2024 22:44
@fatimarabab
Copy link
Collaborator

CPAM0002 showing the new annotations!
Screenshot 2024-12-11 at 4 52 56 PM

Annotating the CILI case as well!
image

Copy link
Collaborator

@fatimarabab fatimarabab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@SeriousHorncat SeriousHorncat merged commit 8ab4f95 into rosalution-0.8.1-patch Dec 11, 2024
8 checks passed
@SeriousHorncat SeriousHorncat deleted the new-annotations-from-opencravat branch December 11, 2024 23:10
SeriousHorncat added a commit that referenced this pull request Dec 11, 2024
* Rendering some of the new linkouts and datasets, with some fixture updates

* Fixed linting and added gnomad to be added as annotations; even though not visualizing yet.  Some additional linkout datasets included also.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants