-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composition API Migration for moving towards real-time collaboration #186
Merged
SeriousHorncat
merged 19 commits into
rosalution-0.8.1-patch
from
composition-api-towards-websocket-integration
Dec 3, 2024
Merged
Composition API Migration for moving towards real-time collaboration #186
SeriousHorncat
merged 19 commits into
rosalution-0.8.1-patch
from
composition-api-towards-websocket-integration
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion API and applying a store to manage the view.
…s for composition api with an analysisStore and view
…the store migration
…ng too long at around 300 something ms
…imrpove unit test runtime in large views.
…ted VueJS' version to be able to use useTempalteRef
…her dialog components
…ty isn't opened correctly by the test
SeriousHorncat
force-pushed
the
composition-api-towards-websocket-integration
branch
from
November 19, 2024 18:00
c8f24c9
to
821c13e
Compare
…al change as an option
…to representing a different analysis when loading a different analysis.
fatimarabab
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go! ✨
SeriousHorncat
deleted the
composition-api-towards-websocket-integration
branch
December 3, 2024 21:19
10 tasks
SeriousHorncat
added a commit
that referenced
this pull request
Dec 11, 2024
…186) * First steps of work in progress to migrate towards using the composition API and applying a store to manage the view. * work in progress for revising tests for composition API and first pass for composition api with an analysisStore and view * Fixed issues discovered during system testing with the first pass of the store migration * first draft of testing done; cut time down in half but its still taking too long at around 300 something ms * Finished cleaning up unit tests for the migrated toast code, and updated VueJS' version to be able to use useTempalteRef * Renaming the RosalutionToast to ToastDialog to correspond with the other dialog components * Secured the specific endpoints by requiring an authenticated user to access them * Updated system test to force click in the situation the menu visibility isn't opened correctly by the test * Fixed the 'AS' characters for the dockerfiles and fixing the accidental change as an option * Fixed issue Rabab found in review; where the store was not switching to representing a different analysis when loading a different analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Pull Request Details
Wrike Ticket - Improving the codebase for the AnalysisView to rely on a store to setup foundation for live realtime-collaboration within Rosalution
Changes made:
To be done in the future:
To Review:
Static Analysis by Reviewer
The changes made to the landing page of an Analysis are working as intended/rendered correctly.
To check this run the following commands:
# From the project root docker compose down docker system prune -a --volumes docker compose up --build
Front end unit tests run successfully on local machine
All GitHub Actions checks have passed.