Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft script to run on every Cilipathies case to update landing page with new sections and fields #181

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

JmScherer
Copy link
Collaborator

@JmScherer JmScherer commented Sep 16, 2024

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines enforced by static analysis tools.
  • My changes generate no new warnings.

Pull Request Details

https://www.wrike.com/open.htm?id=1472359818

Changes made:

  • Added a new migration script etc/fixtures/migrations/migrate-cpam-to-ciliopathies-landing-page.js that will convert a CPAM analysis landing page to a Ciliopathies analysis landing page
  • Added etc/fixtures/import/CILI_2_5K_ARMC9_L510V.json as an example Ciliopathies analysis to upload and test migration

To Review:

  • Static Analysis by Reviewer
  • Start a local version of Roslaution and upload the Ciliopathies analysis
    To check this run the following commands:
    # From the root of Rosalution
    docker compose down
    docker system prune -a --volumes
    
    docker compose up --build -d
    • Go to local.rosalution.cgds/rosalution
    • Login as developer
    • Click on the Create New Analysis card
    • Upload the analysis located at etc/fixtures/import/CILI_2_5K_ARMC9_L510V.json
  • Can you convert the new analysis to contain the new ciliopathies fields?
docker exec -it rosalution-rosalution-db-1 mongosh --eval 'var ciliAnalysis="CILI_2_5K ARMC9_L510V"' 
/tmp/fixtures/migrations/migrate-cpam-to-ciliopathies-landing-page.js
  • Click on the CILI_2_5K ARMC9_L510V analysis card
  • Does the landing page have the new sections?
    • Brief
      • Database
      • Patient Level Variant Information
    • Resources
      • Purchased Antibody Catalog #
      • Physical Resources
    • Reporting
      • Benchling

Screenshots (if appropriate)

Screenshot 2024-09-16 at 4 17 18 PM

Screenshot 2024-09-16 at 4 17 40 PM

Screenshot 2024-09-16 at 4 17 56 PM

@JmScherer JmScherer added the enhancement New feature or request label Sep 16, 2024
@JmScherer JmScherer self-assigned this Sep 16, 2024
Copy link
Collaborator

@SeriousHorncat SeriousHorncat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed updating the specified analysis works!
Screenshot 2024-09-18 at 8 33 33 PM

Screenshot 2024-09-18 at 8 33 44 PM

@JmScherer JmScherer merged commit 0531fba into main Sep 19, 2024
8 checks passed
@JmScherer JmScherer deleted the ciliopathies-sections-script branch September 19, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants