Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the discussion post to show the correct time #172

Merged
merged 1 commit into from
May 6, 2024

Conversation

JmScherer
Copy link
Collaborator

@JmScherer JmScherer commented May 3, 2024

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines enforced by static analysis tools.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.

Pull Request Details

Changes made:

  • Changed the Discussion post string to reflect the user's current timezone

To Review:

  • Static Analysis by Reviewer
  • Does it show the correct time when making a discussion post?
    To check this run the following commands:
    # From the root of Rosalution
    docker system prune -a --volumes
    
    docker compose up --build -d
    • Go to local.rosalution.cgds/rosalution
    • Login with developer
    • Click a case card
    • Scroll down to Discussion and click New Post
    • Make a post
    • Does it have the correct time you posted?
  • All Github Actions checks have passed.

Screenshot 2024-05-03 at 2 42 23 PM

@JmScherer JmScherer added the enhancement New feature or request label May 3, 2024
@JmScherer JmScherer self-assigned this May 3, 2024
@SeriousHorncat SeriousHorncat self-requested a review May 6, 2024 13:20
Copy link
Collaborator

@SeriousHorncat SeriousHorncat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Screenshot says it all! Thanks James!

@JmScherer JmScherer merged commit a9c561a into main May 6, 2024
8 checks passed
@JmScherer JmScherer deleted the fixing-discussion-display-time branch May 6, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants