Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Rosalution is properly ignoring the self signed certificates generated by mkcert #149

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

JmScherer
Copy link
Collaborator

@JmScherer JmScherer commented Nov 20, 2023

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines enforced by static analysis tools.
  • My changes generate no new warnings.

Pull Request Details

Changes made:

  • Updated the .gitignore to include the ./etc/.certificates folder

To Review:

  • Static Analysis by Reviewer
  • Does Rosalution still work as intended?
    To check this run the following commands:
    # From the root of Rosalution
    docker compose down
    docker system prune -a --volumes
    
    ./setup.sh clean
    
    docker compose up --build
    • Go to local.rosalution.cgds/rosalution does it give a security error?
  • Are the ./etc/.certificates certificate files not included in git?
    • Look at git status is anything changed? It should NOT include the .pem files
  • All Github Actions checks have passed.

The .pem files are grey in your vscode indicating that they are not included in git commits
Screenshot 2023-11-20 at 12 48 20 PM

@JmScherer JmScherer added the bug Something isn't working label Nov 20, 2023
@JmScherer JmScherer self-assigned this Nov 20, 2023
@fatimarabab
Copy link
Collaborator

Everything looks good to go!
Screenshot 2023-11-20 at 4 11 38 PM
Screenshot 2023-11-20 at 4 11 52 PM

@JmScherer JmScherer merged commit d0ce762 into main Nov 20, 2023
8 checks passed
@JmScherer JmScherer deleted the ignore-ssl-cert-pem branch November 20, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants