Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animal models updates page correctly #147

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

SeriousHorncat
Copy link
Collaborator

@SeriousHorncat SeriousHorncat commented Oct 23, 2023

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines enforced by static analysis tools.
  • If it is a core feature, I have added thorough tests.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.

Pull Request Details

Wrike Ticket - Create new row item analysis view component to attach a supporting evidence attachment

Changes made:

  • Resolved issue due to an incorrect assumption on what parts of the request to use to update the view.

To Review:

  • Static Analysis by Reviewer

  • The changes made to < describe purpose of change > are working as intended/rendered correctly.
    To check this run the following commands:

    docker compose down
    docker system prune -a --volumes
    docker compose up --build -d
    • Update VMA21 CPAM 0002 case to include attachments for the animal modeling supporting evidence fields
  • All Github Actions checks have passed.

image
image

@SeriousHorncat SeriousHorncat self-assigned this Oct 23, 2023
@SeriousHorncat SeriousHorncat marked this pull request as ready for review October 23, 2023 21:44
@JmScherer
Copy link
Collaborator

Screenshot 2023-10-23 at 4 48 57 PM

Screenshot 2023-10-23 at 4 49 10 PM

Screenshot 2023-10-23 at 4 49 27 PM

Copy link
Collaborator

@JmScherer JmScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works really well!

@SeriousHorncat SeriousHorncat merged commit 6f0f179 into main Oct 23, 2023
8 checks passed
@SeriousHorncat SeriousHorncat deleted the animal-models-updates-page-correctly branch October 23, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants