Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with new Custom Component as Section Row Item for Animal Model #143

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

JmScherer
Copy link
Collaborator

@JmScherer JmScherer commented Oct 13, 2023

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My changes generate no new warnings.

Pull Request Details

https://www.wrike.com/open.htm?id=1225316438

Changes made:

  • Added a prototype: docs/prototypes/csv-to-table-prototype
    • Prototype contains a vuejs vite project that demonstrates adding a CSV test to a text input and generating a table
    • Contains a README.md with table examples

To Review:

  • Static Analysis by Reviewer
  • Run the prototype and create a table
    To check this run the following commands:
    # From the root of Rosalution
    
    cd docs/prototypes/csv-to-table-prototype
    yarn dev
    • Go to the address Vite prints in the console
    • Copy the following into the text box, does it generate a table?
columnA,columnB,columnC
"Susan",41,a
"Mike",5,b
"Jake",33,c
"Jill",30,d
  • All Github Actions checks have passed.

Screenshot 2023-10-13 at 1 18 43 PM

@JmScherer JmScherer added the documentation Improvements or additions to documentation label Oct 13, 2023
@JmScherer JmScherer self-assigned this Oct 13, 2023
Copy link
Collaborator

@SeriousHorncat SeriousHorncat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
image

Success!

@JmScherer JmScherer merged commit d4e3b88 into main Oct 13, 2023
8 checks passed
@JmScherer JmScherer deleted the csv-to-table-prototype branch October 13, 2023 20:33
fatimarabab pushed a commit that referenced this pull request Nov 20, 2023
…odel (#143)

* Updated Rosalution to have the prototype of turning a csv into a table in html

* CSV to Table prototype component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants