Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration script to add new fields for acmg information #135

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

SeriousHorncat
Copy link
Collaborator

@SeriousHorncat SeriousHorncat commented Sep 11, 2023

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines enforced by static analysis tools.
  • My changes generate no new warnings.

Pull Request Details

Wrike Ticket - Add ACMG fields to Brief

Changes made:

  • A migration script to add three new fields to the brief so they can be entered into Rosalution. Opted for three separate fields to ease to parse later if we create more detailed support for ACMG scoring

To Review:

  • Static Analysis by Reviewer

  • The new migration script adds the three new expected fields and render correctly
    To check this run the following commands:

    docker compose down
    docker system prune -a --volumes
    
    docker compose up --build -d
    docker exec rosalution-rosalution-db-1 mongosh /tmp/fixtures/migrations/add-acmg-fields-to-brief.js

    image

  • All Github Actions checks have passed.

@SeriousHorncat SeriousHorncat self-assigned this Sep 11, 2023
@SeriousHorncat SeriousHorncat added the enhancement New feature or request label Sep 11, 2023
@SeriousHorncat SeriousHorncat marked this pull request as ready for review September 11, 2023 16:10
@fatimarabab
Copy link
Collaborator

Screenshot 2023-09-11 at 12 25 19 PM
Script works as expected. Looks good to do!

@SeriousHorncat SeriousHorncat merged commit 80278c3 into main Sep 11, 2023
8 checks passed
@SeriousHorncat SeriousHorncat deleted the acmg-to-add-to-brief branch September 11, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants