Feature/upse 285 #569
Open
Feature/upse 285 #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjagg
reviewed
Dec 30, 2022
| @@ -21,7 +21,7 @@ resourceServerVersion=1.0.48 | |||
| resourceServer13Version=1.3.1 | |||
| sakaiConnectorPortletVersion=1.5.2 | |||
| simpleContentPortletVersion=3.3.2 | |||
| uPortalVersion=5.11.1 | |||
| uPortalVersion=5.11.2-SNAPSHOT | |||
groybal
reviewed
Jan 9, 2023
Comment on lines
-57
to
+61
| ant.gunzip(src: tomcatTarGz, dest: tomcatTarFile.getPath()) | ||
| ant.gunzip(src: tomcatTarGz, dest: tomcatTarFile.getAbsolutePath()) | ||
|
|
||
| // Un-archive the tar file | ||
| copy { | ||
| from tarTree(tomcatTarFile.getPath()) | ||
| from tarTree(tomcatTarFile.getAbsolutePath()) |
There was a problem hiding this comment.
Why were these changes needed? In my Java 11 testing I haven't run into any issues with these.
|
My Java 11 PR (#613) supersedes this one, so I think we can just close this one. I can incorporate the getPath() --> getAbsolutePath() changes into my PR if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Provide support for build/install against Java 11, as well as Java 8