Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade resource-server from 1.3.1 to 1.4.0 #555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: upgrade resource-server from 1.3.1 to 1.4.0 #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ notificationPortletVersion=4.7.3
# Required for very old front-end dependencies
resourceServerVersion=1.0.48
# Includes newer front-end dependencies and web components
resourceServer13Version=1.3.1
resourceServer13Version=1.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhhh why the name of the property contains 13 ? Shouldn't be an other name to distinguish ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.3 is the version that introduced WebJars support, so 1.3 became 13. I agree, It should be updated at some point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested with the 1.4.1 version of the resource server, and it seems good. I didn't deployed on production

sakaiConnectorPortletVersion=1.5.2
simpleContentPortletVersion=3.3.1
uPortalVersion=5.11.0
Expand Down