Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document how to upgrade uPortal-start #448

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bjagg
Copy link
Member

@bjagg bjagg commented Apr 22, 2020

Checklist
Description of change

@bjagg bjagg self-assigned this Apr 22, 2020
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjagg!
This is a good guide to have 👍

Could this file be linked from docs/en/README.md to make it more visible?


Edit `cradle.properties`, replacing all those lines with something suitable. In this case, the resolution is simply

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```properties

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this should be gradle.properties and not cradle.properties

@jgribonvald
Copy link
Contributor

Hi folks,
It would be a good practice if you could add the doc also for fr even if it's in English. It's important to have all docs for all langage even if it's not in the good language. At least it avoid to miss something, and I think it will encourage peoples to purpose a translation.

Copy link
Contributor

@jgribonvald jgribonvald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typo, and please add this doc, even if it's in English, to the French doc (like other missing).
Else thanks for a such documentation, not everyone know how to works with git !


#### `etc/portal/`

The intention of files in this folder are two show the most commonly configured properties and to set a baseline for a dev environment. Real credentials **SHOULD NEVER BE STORED IN THIS FILES** exception for generic dev ones.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there isn't a typo ?
IN THIS FILES ?


The intention of files in this folder are two show the most commonly configured properties and to set a baseline for a dev environment. Real credentials **SHOULD NEVER BE STORED IN THIS FILES** exception for generic dev ones.

Like `data/` these folder should be reviewed for changes and then updates made even if there are no conflicts. For example, a dependency change required that signature keys now meet a minimal size and format around uPortal version 5.5. This is in the upstream files along with comments on creating the keys.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there isn't a typo ?
these folder should


Edit `cradle.properties`, replacing all those lines with something suitable. In this case, the resolution is simply

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this should be gradle.properties and not cradle.properties

```
notificationPortletVersion=4.5.3
```
As noted above, mark this file as resolved with `git add cradle.properties` (for this example).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above cradle.properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants