libext2fs: fix ext2fs_orphan_file_block_csum_set()

The function ext2fs_orphan_file_block_csum_set() isn't used by e2fsprogs, but it was embarassingly broken. Thanks to Darrick Wong for pointing this out. Fixes: 16534ff ("e2fsck: fix big-endian support for orphan_file...") Signed-off-by: Theodore Ts'o <[email protected]>
tytso · Dec 5, 2024 · daf2d1c · daf2d1c
1 parent cd25c24
commit daf2d1c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/ext2fs/orphan.c b/lib/ext2fs/orphan.c
@@ -250,14 +250,16 @@ errcode_t ext2fs_orphan_file_block_csum_set(ext2_filsys fs, ext2_ino_t ino,
 					    blk64_t blk, char *buf)
 {
 	struct ext4_orphan_block_tail *tail;
+	errcode_t ret;
 	__u32 crc;
 
 	if (!ext2fs_has_feature_metadata_csum(fs->super))
 		return 0;
 
 	tail = ext2fs_orphan_block_tail(fs, buf);
-	return ext2fs_orphan_file_block_csum(fs, ino, blk, buf, &crc);
+	ret = ext2fs_orphan_file_block_csum(fs, ino, blk, buf, &crc);
 	tail->ob_checksum = ext2fs_cpu_to_le32(crc);
+	return ret;
 }
 
 int ext2fs_orphan_file_block_csum_verify(ext2_filsys fs, ext2_ino_t ino,