Support all string properties of wptType tags #13
Conversation
joukewitteveen
force-pushed
the
master
branch
2 times, most recently
from
3713bda to
c00bae2
Compare
joukewitteveen
force-pushed
the
master
branch
from
c00bae2 to
9e0579e
Compare
|
I extended this PR with support for links. With this, most of a waypoint survives a pass through I also included a fix for an older typo. This should have been a separate PR, but given the low activity on this project I decided to just stick it in here. |
|
Any ideas on this PR? Note that it is meant to be independent of #11. While this PR adds support for more waypoint properties, it does not expose any transformers. It also does nothing to make |
| tags: { name: "name" }, | ||
| name: "not_name" | ||
| tags: { id: "name" }, | ||
| ref: "not_name" |
There was a problem hiding this comment.
This reflects a change in property precedence when configuring a name.
Before this pull request, the options were, in order of decreasing precedence:
- inferred from tags (
tags.name,tags.id,tags.ref) - inferred from bare properties (
name,id,ref)
After this pull request, the options would be, in order of decreasing precedence:
- explicit in a bare property (
name) - inferred from tags (
tags.name,tags.id,tags.ref) - inferred from bare properties (
name,id,ref)
Note that the occurrence of name in the third option is superfluous.
Because of this change in precedence, I suggest that the next version would be 0.6.0, if this PR is accepted.
|
Ping? |
Support all string properties of the GPX wptType type. For the name and description tag, the user callback is used as a fallback. The callbacks are always used for tags that are not of the wptType type.
GPX elements may contain multiple links, each potentially containing a text element and a type element. Take these from a "links" array in the properties of a feature if present and fallback to the featureLink callback otherwise.
joukewitteveen
force-pushed
the
master
branch
2 times, most recently
from
e5c43e6 to
05c12e9
Compare
|
I force-pushed a new version that does away with the |
|
Ping? |
|
Ping? I would still like to see this improved support for a round-trip via |
Waypoints (wpt), route points (rtept), and track points (trkpt) share the same type (wptType) in the GPX schema. It makes sense to centralize the code that generates these tags.
Doing so makes it possible to implement more of the supported children. I implemented support for all string based child tags. This is especially nice in conjunction with mapbox/togeojson, which reads those tags.