Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Checker Framework version 3.19.0 #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use Checker Framework version 3.19.0 #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da209b2
Use Checker Framework version 3.19.0
mernst Dec 2, 2021
267280f
Adjust README
mernst Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions README-typetools.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,21 @@ This creates file
To update to a newer version of the upstream library
----------------------------------------------------

Create a branch and do work thre.
First, update to use the latest Checker Framework by editing file
`pom.xml` (3 places, for `checker-qual` and `checker`).
Ensure that it builds:
```
mvn -B -Dmaven.test.skip=true package
```
Make a pull request to ensure that type-checking succeeds.

Now, do the upstream library update.
Create a branch and do work there.

At https://github.com/apache/commons-io/releases ,
find the commit corresponding to a public release.

Commons IO version 2.8.0 is commit fa59009aaabcf8671a8d741993ef355f42b95ccd
Commons IO version 2.11.0 is commit 8985de8fe74f6622a419b37a6eed0dbc484dc128

Pull in that commit:
```
Expand All @@ -29,8 +38,6 @@ git pull https://github.com/apache/commons-io <commitid>

Update the version number throughout this file.

Use the latest Checker Framework version by changing `pom.xml`.

Search the codebase for all uses of "@since 2.8.0" and annotate those methods/classes.

Ensure that it builds:
Expand Down
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ file comparators, endian transformation classes, and much more.
<dependency>
<groupId>org.checkerframework</groupId>
<artifactId>checker-qual</artifactId>
<version>3.17.0</version>
<version>3.19.0</version>
</dependency>
<dependency>
<groupId>com.google.errorprone</groupId>
Expand Down Expand Up @@ -537,7 +537,7 @@ file comparators, endian transformation classes, and much more.
<path>
<groupId>org.checkerframework</groupId>
<artifactId>checker</artifactId>
<version>3.17.0</version>
<version>3.19.0</version>
</path>
</annotationProcessorPaths>
<annotationProcessors>
Expand All @@ -558,7 +558,7 @@ file comparators, endian transformation classes, and much more.
<dependency>
<groupId>org.checkerframework</groupId>
<artifactId>checker</artifactId>
<version>3.17.0</version>
<version>3.19.0</version>
</dependency>
</dependencies>
</profile>
Expand Down