Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pbrisbin/setup-tool-action@v2 #25

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

Vampire
Copy link
Collaborator

@Vampire Vampire commented Aug 18, 2024

@krzema12 krzema12 merged commit 5cc9e3f into typesafegithub:main Aug 18, 2024
Vampire added a commit that referenced this pull request Aug 18, 2024
@Vampire Vampire deleted the setup-tool-action branch August 18, 2024 20:54
@Vampire
Copy link
Collaborator Author

Vampire commented Aug 26, 2024

Upstream PR was merged 🎉 (not released yet, but probably soon)

@krzema12
Copy link
Member

@Vampire I think it's released. Let's leave the typings here to support older minor/patch versions, right?

@Vampire
Copy link
Collaborator Author

Vampire commented Aug 26, 2024

Yes, now it is. :-)
Yes, generally leaving it in the catalog for older versions does make sense.
But for #28 you removed them for whatever reason. 🤷‍♂️
I don't care either way, I don't yet use it productively.

@krzema12
Copy link
Member

I did so historically, just was too excited that some action got the typings 😊 But then considered what you wrote and agreed that we should leave them if new versions of a given major version appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants