Spelling #990

jsoref · 2022-07-31T16:13:13Z

Description

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@5a440c4#commitcomment-79875390

How Has This Been Tested?

The action reports that the changes in this PR would make it happy: jsoref@28d74f3

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation change
Test suite change

It's quite possible there are breaking changes. I fully expect this will need to be split or something. I'm very comfortable w/ working on large changesets. I just need direction about how each project prefers to address them.

Checklist:

I have read the CONTRIBUTING document.

jsoref

checkpointing

jsoref · 2022-07-31T16:14:01Z

compiler/Eta/Backpack/NameShape.hs

@@ -150,7 +150,7 @@ ns_module = mkHoleModule . ns_mod_name
 -- | Substitution on @{A.T}@.  We enforce the invariant that the
 -- 'nameModule' of keys of this map have 'moduleUnitId' @hole@
 -- (meaning that if we have a hole substitution, the keys of the map
-- are never affected.)  Alternately, this is ismorphic to
+-- are never affected.)  Alternately, this is isomorphic to


Most corrections were automatically suggested by Google Sheets. This is amongst them. In general, I don't fight Google except when I have sufficient experience to know it's wrong.

jsoref · 2022-07-31T16:14:29Z

compiler/Eta/BasicTypes/DataCon.hs

@@ -789,7 +789,7 @@ dataConUnivTyVars = dcUnivTyVars
 dataConExTyVars :: DataCon -> [TyVar]
 dataConExTyVars = dcExTyVars

-- | Both the universal and existentiatial type variables of the constructor
+-- | Both the universal and existential type variables of the constructor


I'm not sure about this. Google suggested existentialism but that didn't seem right...

jsoref · 2022-07-31T16:15:17Z

compiler/Eta/BasicTypes/Demand.hs

@@ -1686,8 +1686,8 @@ a demand on the Id into a DmdType, which gives
        c) an indication of the result of applying
           the Id to its arguments

-However, in fact we store in the Id an extremely emascuated demand
-transfomer, namely
+However, in fact we store in the Id an extremely emasculated demand


jsoref · 2022-07-31T16:16:22Z

compiler/Eta/BasicTypes/Id.hs

-                -- These are are implied by their type or class decl;
+                -- These are implied by their type or class decl;


Doubled words are usually typos and my tooling flags them and I try to correct them by hand. There are certain cases where the algorithm is wrong. Generally that that is acceptable/intended. Here, I don't think the doubling is intended, and hence I've removed it.

jsoref · 2022-07-31T16:17:18Z

compiler/Eta/BasicTypes/Literal.hs

-When we initally build an Integer literal, notably when
-deserialising it from an interface file (see the Binary instance
+When we initially build an Integer literal, notably when
+deserializing it from an interface file (see the Binary instance


Google suggested this. Generally I leave -ise British variants alone. But the Internet agrees that this -z/-s variation doesn't exist.

jsoref · 2022-07-31T16:30:20Z

compiler/Eta/SimplCore/SimplUtils.hs

@@ -822,15 +822,15 @@ Similarly, consider
 and suppose that there are auto-generated specialisations and a strictness
 wrapper for g.  The specialisations get activation AlwaysActive, and the
 strictness wrapper get activation (ActiveAfter 0).  So the strictness
-wrepper fails the test and won't be inlined into f's stable unfolding. That
+wrapper fails the test and won't be inlined into f's stable unfolding. That


probably (esp. since the spelling varies in this file).

jsoref · 2022-07-31T16:30:39Z

compiler/Eta/SimplCore/SimplUtils.hs

@@ -1155,7 +1155,7 @@ postInlineUnconditionally dflags env top_lvl bndr occ_info rhs unfolding
        --      case v of
        --         True  -> case x of ...
        --         False -> case x of ...
-        -- This is very important in practice; e.g. wheel-seive1 doubles
+        -- This is very important in practice; e.g. wheel-sieve1 doubles


jsoref · 2022-07-31T16:32:53Z

compiler/Eta/TypeCheck/TcDeriv.hs

@@ -1129,7 +1129,7 @@ The DeriveAnyClass extension adds a third way to derive instances, based on
 empty instance declarations.

 The canonical use case is in combination with GHC.Generics and default method
-signatures. These allow us have have instance declarations be empty, but still
+signatures. These allow us to have instance declarations be empty, but still


This is one of those cases where I manually adjusted...

jsoref · 2022-07-31T16:33:42Z

compiler/Eta/TypeCheck/TcFlatten.hs

@@ -411,7 +411,7 @@ flatten


 ----------------------------
-indexed-types/should_failt/T4179
+indexed-types/should_fail/T4179


compiler/Eta/TypeCheck/TcFlatten.hs

jsoref · 2022-07-31T16:37:26Z

compiler/Eta/TypeCheck/TcType.hs

@@ -753,7 +753,7 @@ isReturnTyVar tv

 -- isAmbiguousTyVar is used only when reporting type errors
 -- It picks out variables that are unbound, namely meta
-- type variables and the RuntimUnk variables created by
+-- type variables and the RuntimeUnk variables created by


jsoref · 2022-07-31T16:38:04Z

compiler/Eta/Types/CoAxiom.hs

@@ -340,7 +340,7 @@ enclosing class or instance.  Consider
     type F Int [z] = ...   -- Second param must be [z]

 In the CoAxBranch in the instance decl (F Int [z]) we use the
-same 'z', so that it's easy to check that that type is the same
+same 'z', so that it's easy to check that the type is the same


I spent quite a bit of time on this one. I'm not confident about it, but...

jsoref · 2022-07-31T16:39:45Z

compiler/Eta/Types/TypeRep.hs

@@ -380,7 +380,7 @@ as ATyCon.  You can tell the difference, and get to the class, with
 The Class and its associated TyCon have the same Name.
 -}

-- | A typecheckable-thing, essentially anything that has a name
+-- | A typechecked-thing, essentially anything that has a name


probably wrong

jsoref · 2022-07-31T16:41:05Z

compiler/Eta/Utils/Platform.hs

-              platformUnregisterised           :: Bool,
+              platformUnregistered           :: Bool,


Curious about this term. Again, not confident (betting it'll be rejected). If the change is ok, then I'd adjust the indentation.

jsoref · 2022-07-31T16:41:51Z

docs/0-user-guides/1-etlas-user-guide/3-configuration/1-dependency-management.md

-If the package `eta-spark-core` with the exact same version as in the commit specified can be found in Hacakge or Etlas Index, the GitHub location will override the other search locations. This makes it easy to depend on forked versions of existing libraries when the released versions of those libraries don't contain the functionality required for your project.
+If the package `eta-spark-core` with the exact same version as in the commit specified can be found in Hackage or Etlas Index, the GitHub location will override the other search locations. This makes it easy to depend on forked versions of existing libraries when the released versions of those libraries don't contain the functionality required for your project.


jsoref · 2022-07-31T16:43:47Z

libraries/base/GHC/Float.hs

@@ -14,7 +14,7 @@
 -- |
 -- Module      :  GHC.Float
 -- Copyright   :  (c) The University of Glasgow 1994-2002
--                Portions obtained from hbc (c) Lennart Augusstson
+--                Portions obtained from hbc (c) Lennart Augustsson


jsoref · 2022-07-31T16:44:07Z

libraries/base/GHC/IO.hs

-        -- To and from from ST
+        -- To and from ST


jsoref · 2022-07-31T16:45:28Z

libraries/base/GHC/IO/Handle/Internals.hs

@@ -676,7 +676,7 @@ mkDuplexHandle dev filepath mb_codec tr_newlines = do
       mkHandle dev filepath WriteHandle Nothing mb_codec
                        tr_newlines
                        (Just handleFinalizer)
-                        Nothing -- no othersie
+                        Nothing -- no otherside


Possibly otherwise, but given there are sides a few lines below...

jsoref · 2022-07-31T16:45:51Z

libraries/base/GHC/List.hs

@@ -86,7 +86,7 @@ last []                 =  errorEmptyList "last"
 #else
 -- Use foldl to make last a good consumer.
 -- This will compile to good code for the actual GHC.List.last.
-- (At least as long it is eta-expaned, otherwise it does not, #10260.)
+-- (At least as long it is eta-expand, otherwise it does not, #10260.)


possibly expanded?

jsoref · 2022-07-31T16:47:12Z

rts/src/main/java/eta/runtime/stg/StgContext.java

@@ -386,7 +386,7 @@ public static StgContext acquire() {
    public final void dump() {
        System.out.println("Context Dump");
        System.out.println("currentTSO: " + currentTSO);
-        System.out.println("myCapabilitymyCapability: " + myCapability);
+        System.out.println("myCapability: " + myCapability);


Signed-off-by: Josh Soref <[email protected]>

jsoref commented Jul 31, 2022

View reviewed changes

jsoref force-pushed the spelling branch from 2a4a1f4 to 4072724 Compare July 31, 2022 16:49

jsoref added 27 commits July 31, 2022 13:13

spelling: invariant

f7f4aa9

Signed-off-by: Josh Soref <[email protected]>

spelling: invisible

fa79843

Signed-off-by: Josh Soref <[email protected]>

spelling: invocation

55709b6

Signed-off-by: Josh Soref <[email protected]>

spelling: involves

65fb105

Signed-off-by: Josh Soref <[email protected]>

spelling: isomorphic

475da57

Signed-off-by: Josh Soref <[email protected]>

spelling: just

6e0cc75

Signed-off-by: Josh Soref <[email protected]>

spelling: lambdas

67cbbd9

Signed-off-by: Josh Soref <[email protected]>

spelling: laziness

6df9f4c

Signed-off-by: Josh Soref <[email protected]>

spelling: legal

e4f6536

Signed-off-by: Josh Soref <[email protected]>

spelling: legitimate

dd15bf4

Signed-off-by: Josh Soref <[email protected]>

spelling: legitimately

857114c

Signed-off-by: Josh Soref <[email protected]>

spelling: like

179072f

Signed-off-by: Josh Soref <[email protected]>

spelling: local

60fc4f5

Signed-off-by: Josh Soref <[email protected]>

spelling: looks

1891495

Signed-off-by: Josh Soref <[email protected]>

spelling: mapping

3ad8302

Signed-off-by: Josh Soref <[email protected]>

spelling: maximises

cf8dd30

Signed-off-by: Josh Soref <[email protected]>

spelling: maximum

45f7cd5

Signed-off-by: Josh Soref <[email protected]>

spelling: maybe

3c5b581

Signed-off-by: Josh Soref <[email protected]>

spelling: meaning

33a3e9a

Signed-off-by: Josh Soref <[email protected]>

spelling: member

e5e1895

Signed-off-by: Josh Soref <[email protected]>

spelling: mentions

83eed28

Signed-off-by: Josh Soref <[email protected]>

spelling: messages

aee01fe

Signed-off-by: Josh Soref <[email protected]>

spelling: metaprogramming

806b510

Signed-off-by: Josh Soref <[email protected]>

spelling: miscellaneous

a2cc8cb

Signed-off-by: Josh Soref <[email protected]>

spelling: models

80cd8d0

Signed-off-by: Josh Soref <[email protected]>

spelling: modification

675bed4

Signed-off-by: Josh Soref <[email protected]>

spelling: module

dc2e95d

Signed-off-by: Josh Soref <[email protected]>

jsoref added 29 commits July 31, 2022 13:13

spelling: unifiable

c174b7a

Signed-off-by: Josh Soref <[email protected]>

spelling: unification

6f86fd5

Signed-off-by: Josh Soref <[email protected]>

spelling: unified

9de19d5

Signed-off-by: Josh Soref <[email protected]>

spelling: universal

4ac1a4e

Signed-off-by: Josh Soref <[email protected]>

spelling: universally

07becdd

Signed-off-by: Josh Soref <[email protected]>

spelling: unnecessary

c70262a

Signed-off-by: Josh Soref <[email protected]>

spelling: unregistered

c8bf616

Signed-off-by: Josh Soref <[email protected]>

spelling: unsatisfied

c1946c4

Signed-off-by: Josh Soref <[email protected]>

spelling: untouchable

2b1af43

Signed-off-by: Josh Soref <[email protected]>

spelling: utilities

3409664

Signed-off-by: Josh Soref <[email protected]>

spelling: variable

93c6b03

Signed-off-by: Josh Soref <[email protected]>

spelling: variables

265add6

Signed-off-by: Josh Soref <[email protected]>

spelling: variants

fd6f978

Signed-off-by: Josh Soref <[email protected]>

spelling: verbatimly

76f612b

Signed-off-by: Josh Soref <[email protected]>

spelling: version

5b884d1

Signed-off-by: Josh Soref <[email protected]>

spelling: vigorously

bdf9d0e

Signed-off-by: Josh Soref <[email protected]>

spelling: want

adfa55d

Signed-off-by: Josh Soref <[email protected]>

spelling: whatever

6cbbbd2

Signed-off-by: Josh Soref <[email protected]>

spelling: when

3d82a22

Signed-off-by: Josh Soref <[email protected]>

spelling: whenever

c5dd24a

Signed-off-by: Josh Soref <[email protected]>

spelling: where

751a9c5

Signed-off-by: Josh Soref <[email protected]>

spelling: whether

722700b

Signed-off-by: Josh Soref <[email protected]>

spelling: which

0e60ba8

Signed-off-by: Josh Soref <[email protected]>

spelling: with

2b03841

Signed-off-by: Josh Soref <[email protected]>

spelling: working

0b2bb38

Signed-off-by: Josh Soref <[email protected]>

spelling: would

a4178ef

Signed-off-by: Josh Soref <[email protected]>

spelling: wrapper

271908a

Signed-off-by: Josh Soref <[email protected]>

spelling: write

76a3afb

Signed-off-by: Josh Soref <[email protected]>

spelling: writing

8704d2e

Signed-off-by: Josh Soref <[email protected]>

jsoref force-pushed the spelling branch from 4072724 to 8704d2e Compare July 31, 2022 17:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #990

Spelling #990

jsoref commented Jul 31, 2022

jsoref left a comment

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

jsoref Jul 31, 2022

		-- These are are implied by their type or class decl;
		-- These are implied by their type or class decl;

		platformUnregisterised :: Bool,
		platformUnregistered :: Bool,

		If the package `eta-spark-core` with the exact same version as in the commit specified can be found in Hacakge or Etlas Index, the GitHub location will override the other search locations. This makes it easy to depend on forked versions of existing libraries when the released versions of those libraries don't contain the functionality required for your project.
		If the package `eta-spark-core` with the exact same version as in the commit specified can be found in Hackage or Etlas Index, the GitHub location will override the other search locations. This makes it easy to depend on forked versions of existing libraries when the released versions of those libraries don't contain the functionality required for your project.

Spelling #990

Are you sure you want to change the base?

Spelling #990

Conversation

jsoref commented Jul 31, 2022

Description

How Has This Been Tested?

Types of changes

Checklist:

jsoref left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment