Make the script example scrollable so it can be copied easily #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On index.html there is a code tag which shows an example script tag to include hogan.js on your site. This code tag is not scrollable and the majority of the content is hidden. Scrolling is not possible, which makes it really hard to copy the URL. This change sets `overflow` to `auto` on `code` and `pre` elements. The layout stays the same, but now the content is scrollable and it's possible to copy the script tag.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into "problems" while trying to copy the script tag on into my code. It's this one here:
The
pre/codetags are not scrollable and I had to change theoverflowattribute in my browser dev tools to copy the script tag.Now, this commit makes this change permanent and allows to scroll/copy the example script tag again.
What do you think? Another solution I thought of was to change the layout and move the whole script tag code snippet and the text to a separate row:
If this is a better solution (since the scrollbars might look ugly on different systems), I'll happily close this PR and open another one with the separate row.