Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed error handling for some SQL errors #281

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

Xemdo
Copy link
Contributor

@Xemdo Xemdo commented Oct 1, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

sqlite3 package was causing me some issues on vscode because of golang/vscode-go#2988, so while waiting for that to resolve I figured I'd remove the error old SQL error handling here.

It seemed like it wasn't necessary as it was only used by one Mock API call to see if the Category ID existed in the database, which I replaced with an additional database call.

Description of Changes:

  • Removed old SQL error handling
  • Changed PATCH /mock/channels to check if the game category exists when its being updated

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@Xemdo Xemdo merged commit b2ef8db into main Oct 10, 2023
@Xemdo Xemdo deleted the rework-sql-error-handling branch October 10, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant