Merge pull request #114 from amazur31/throw-error-for-null-factory

Fix for NullReferenceException when GetService<IHttpClientFactory>() fails
twitchax · Aug 30, 2024 · bdc100b · bdc100b
2 parents 3db53a6 + e9393fd
commit bdc100b
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/Core/Extensions/Http.cs b/src/Core/Extensions/Http.cs
@@ -20,9 +20,10 @@ internal static async Task ExecuteHttpProxyOperationAsync(this HttpContext conte
 
             try
             {
-                var httpClient = context.RequestServices
-                    .GetService<IHttpClientFactory>()
-                    .CreateClient(options?.HttpClientName ?? Helpers.HttpProxyClientName);
+                var clientFactory = context.RequestServices.GetService<IHttpClientFactory>()
+                ?? throw new InvalidOperationException("IHttpClientFactory not registered. You need to add builder.Services.AddHttpClient(); during startup");
+
+                var httpClient = clientFactory.CreateClient(options?.HttpClientName ?? Helpers.HttpProxyClientName);
 
                 // If `true`, this proxy call has been intercepted.
                 if(options?.Intercept != null && await options.Intercept(context).ConfigureAwait(false))