Accept and pass on a prefix value. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
- Coverage 96.37% 95.93% -0.44%
==========================================
Files 74 74
Lines 8910 8934 +24
Branches 630 634 +4
==========================================
- Hits 8587 8571 -16
- Misses 202 232 +30
- Partials 121 131 +10
Continue to review full report at Codecov.
|
markrwilliams
previously requested changes
Aug 24, 2017
There was a problem hiding this comment.
Thank you for this API improvement! The patch's content is good but incomplete: Please add an integration test to txaws.testing.s3_tests, and, because txaws evidently uses towncrier, a feature newsfragment.
markrwilliams
approved these changes
Aug 24, 2017
| @@ -91,12 +94,24 @@ def delete_bucket(self, bucket): | |||
| return succeed(None) | |||
|
|
|||
| @_rate_limited | |||
| def get_bucket(self, bucket): | |||
| def get_bucket(self, bucket, prefix=None): | |||
There was a problem hiding this comment.
Good catch - this also needed to be updated!
| return succeed(pieces["listing"]) | ||
| listing = pieces["listing"] | ||
| if prefix is not None: | ||
| listing = attr.assoc( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78