Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial implementation #1

Merged
merged 63 commits into from
Dec 12, 2023
Merged

feat: initial implementation #1

merged 63 commits into from
Dec 12, 2023

Conversation

cgrindel
Copy link
Contributor

@cgrindel cgrindel commented Dec 8, 2023

  • The initial implementation for the action.
    • /tools/run_nix_shell.sh: The core logic for the action.
    • /action.yaml: The GitHub action definition.
  • Nix configuration files to support the testing of the action (/flake.nix, /flake.lock, /nixpkgs.nix).
  • Unit tests (/tests/tools_tests) that can be exercised using Bazel.
  • Files used in the integration tests (/tests/integration_tests). The actual integration tests are defined in the CI workflow file.
  • A CI workflow to test PRs and run a daily build.
  • README.md with usage information.

Related to https://github.com/tweag/scalable-builds-group/issues/97.
Related to https://github.com/tweag/scalable-builds-group/issues/138.

@cgrindel cgrindel self-assigned this Dec 8, 2023
@cgrindel cgrindel requested a review from avdv December 8, 2023 20:22
@cgrindel cgrindel marked this pull request as ready for review December 8, 2023 20:22
@cgrindel
Copy link
Contributor Author

cgrindel commented Dec 8, 2023

@avdv This ended up being bigger than I originally thought it would be. I am willing to break it up into smaller PRs if you prefer. Just let me know.

Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@cgrindel cgrindel merged commit 5dd9179 into main Dec 12, 2023
7 checks passed
@cgrindel cgrindel deleted the initial_files branch December 12, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants