Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitwise-and BitwiseAnd for Int and Word #419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yaitskov
Copy link

No description provided.

@aspiwack
Copy link
Member

Hello,

Thanks for your PR. Can you elaborate on your design? Why create a BitwiseAnd class, in particular?

@yaitskov
Copy link
Author

yaitskov commented May 25, 2022

Thanks for your PR. Can you elaborate on your design? Why create a BitwiseAnd class, in particular?

I was trying to mimic linear-base approach on tackling Num class i.e. a class per method.
Data.Bits class is pretty populated with methods too.
I haven't defined Bits in PR just because not sure about getting review responses so saved on initial efforts ;).

I don't have strong opinion about particular class name and open to alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants