Adding Deques #292
Adding Deques #292
Conversation
| -- | ||
| -- It is designed to be imported qualfied: | ||
| -- | ||
| -- > import qualfied Data.Deque.Mutable.Linear as Deque |
There was a problem hiding this comment.
I think it is crucial to mention that this is a bounded deque. I would even call it Data.Dequeue.Bounded.Mutable.Linear instad. It would also be good to mention:
- That the underlying storage is an array
- When full, newer elements overwrite the older elements
There was a problem hiding this comment.
It doesn't overwrite. It crashes if you try to fill it after it's full. I think that makes more sense.
There was a problem hiding this comment.
I am having a hard time thinking when would I require a queue where I certainly know that it will contain less than some number of elements. I can think of cases where it's okay to be forgetful, or don't accept the new element, or in concurrent cases (which is not the case in this code) it should block; but in all cases I can think of there is no guarantee that the queue is not empty or it is not full.
Even if we go with the crashy version, we should still mention that it is a bounded queue.
There was a problem hiding this comment.
I agree with adding comments saying it is bounded. But ...
Do you think it's just better for me to use array resizing internally and have an unbounded structure to begin with? I feel like your argument makes sense and I can't think of a case where we want a bounded queue or stack.
There was a problem hiding this comment.
Did this ^, done.
Divesh-Otwani
force-pushed
the
data/deque
branch
from
122b46b
to
0bf070c
Compare
|
Just going to comment that I don't know how I closed this a moment ago. I think I accidentally used a strange key-sequence or something that caused that. |
|
Sorry for the radio silence. For now I think we should hold off merging this PR (alongside with other new collection PR's #293 and #295), because we already have some performance issues with our existing linear collections; and having even more collections built on top of them would not solve that. Once we get their performance right, we should take another look at these PR's, so we can merge them more confidently of their usefulness. |
|
Dude I agree. Let's do things right and try to only keep solid stuff in the codebase. |
I wanted to build out a few data structures that are relatively easy to get out. This is one of them.