-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable OpenSSF Scorecard Github Action and Badge #37402
Conversation
Signed-off-by: Joyce Brum <[email protected]>
@mdo: What's your take on this? I removed the link since there isn't a human readable page to link to. Overall, the checks are OK, I mostly disagree with the Actions pinning for the reasons I mentioned above. The other things are generally considered good practices. That being said, 7.2 is not good enough either and it's mostly caused by Actions not being pinned AFAICT. |
BTW, maybe we could link to https://bestpractices.coreinfrastructure.org/en/projects/2930 and add the best practices badge? It seems @bardiharborow set this up, not sure how to get updated results or access ourselves. |
About wheter the Pinned-Dependencies has a big weight in the current score, I've made some calculations: “Critical” risk checks are weighted at 10 ( 10 * (Dangerous-Workflow) + 7.5 * (Binary-Artifacts + Branch-Protection + Code-Review + Dependency-Update-Tool + Maintained + Signed-Releases + Token-Permissions + Vulnerabilities) + 5 * (Fuzzing + Pinned-Dependencies + Then, considering the current score: Even if the Pinned Dependencies was a 10, the score would only go to 7.6. According this, the best approach would be:
Working only to get this four to 10 would increase the score to 9.6 |
@XhmikosR it says that everyone with commit access to the repository should have access already, but if not, I can manually add user IDs to the access list. |
I'm going to give this a go and we revert it if we don't like it later. |
Signed-off-by: Joyce Brum [email protected]
CC @XhmikosR
Description
Any doubts or concerns please let me know.
Motivation & Context
Closes #37343
It enables the OpenSSF Scorecard Github Action and Badge to help you to ensure the project will continue to follow the open source best practices or even improve any possible practice to avoid security risks and vulnerabilities.
Type of changes
Checklist
npm run lint
)Live previews
https://github.com/joycebrum/bootstrap#status
Related issues
#37343