-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer fix #773
Closed
Closed
Footer fix #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Style adjustments to live header
Live compact adjustments
fix: hide video button if videos hidden
fix: hide backticks from inline code blocks in prose (markdown)
feature: renable enrollment support
Simplify Tutors Time presentation
upgeades: sveltekit 2, view 5, firebase 10 + markdown-it upgrades & others
Update config to match latest svelte, vite and tailwind config structure
fetch latest user name if not present in time
enrolled students on calendar only
adjust .env.example to latest version + knock on changes to run without database keys
Lab navigation stickey now enhancing usability
Mobile style adjustments for tutors.dev home page
Major reorg: move mono repo to tutors-apps repo. Keep this repo focussed on reader
home + readme updates
edit button for open source courses supported [edit button](https://tutors.dev/course/tutors-reference-manual#edit-course-button)
On Active live view, do not show anon users
License + readme updates
Integrate simulator
fix: Card subtitle title to use lo not course title
fixes for mobiel simulator
tutors-sdk#693 - contributing guidelines + readme update
close tutors-sdk#690: Auth page links and wording
Tutors message string in footer
footer fix + holobyte + readme updates
search auth focus, simulator + readme updates
tutors-sdk#722: support "archive" and "archives" in lab/notes
search result ux changes + support for PDF labs + package updates (excluding partykit for the moment)
Supabase & PartyKit library updates (+others)
fix: correct import for Session type
refactor metrics to firebase-metrics, placeholders for supabase-metrics
Tutors Design panels on the home page
Major Theme System Reorganisation
architecture diagram updates
tutors next analytics - in parellel with firebase
Minor analytics fixes
Redesign time navigation
Sortable tutors time feature
tutors time mean calendar introduced
simulator for red hat open conference
revised calendar layout
fix: remove 'github' from title
Hmmm not sure what git has done here going to close this and figure it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This introduces a change to satisfy #705 by pointing the footer message to a Github Pages repo.
If @edeleastar can create a Gitlab Pages I can adjust the URL within the code to reflect a Github repo living under the Tutors-sdk project by pointing to the raw content. Optionally this can go one further and abstract it as a variable to a master config file (the .env perhaps) if a further issue wishes to explore this.
The footer is rendering slightly smaller than the current version, I played around with the markdown and if I use the header approach the font jumps signficantly, so a caution there, this should just be a flat text file with no real stylistic formatting. My CSS skills are too low to go exploring how to get this back to the right size so any suggestions and I can add them into the PR
What commits does this PR relate to?
TutorsMessage.svelte
Thank you for your contribution
We hope you stay around and connect with our growing community!