Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer fix #773

Closed
wants to merge 43 commits into from
Closed

Footer fix #773

wants to merge 43 commits into from

Conversation

lgriffin
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message is sensible and easily understood
  • Tests for the changes have been added (for bug fixes / features where relevant)
  • Docs have been added / updated (for bug fixes / features where relevant)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This introduces a change to satisfy #705 by pointing the footer message to a Github Pages repo.

If @edeleastar can create a Gitlab Pages I can adjust the URL within the code to reflect a Github repo living under the Tutors-sdk project by pointing to the raw content. Optionally this can go one further and abstract it as a variable to a master config file (the .env perhaps) if a further issue wishes to explore this.

The footer is rendering slightly smaller than the current version, I played around with the markdown and if I use the header approach the font jumps signficantly, so a caution there, this should just be a flat text file with no real stylistic formatting. My CSS skills are too low to go exploring how to get this back to the right size so any suggestions and I can add them into the PR

What commits does this PR relate to?

TutorsMessage.svelte

Thank you for your contribution

We hope you stay around and connect with our growing community!

fix: hide video button if videos hidden
fix: hide backticks from inline code blocks in prose (markdown)
upgeades: sveltekit 2, view 5, firebase 10 + markdown-it upgrades & others
Update config to match latest svelte, vite and tailwind config structure
fetch latest user name if not present in time
adjust .env.example to latest version + knock on changes to run without database keys
Lab navigation stickey now enhancing usability
Mobile style adjustments for tutors.dev home page
Major reorg: move mono repo to tutors-apps repo. Keep this repo focussed on reader
On Active live view, do not show anon users
fix: Card subtitle title to use lo not course title
footer fix + holobyte + readme updates
search auth focus, simulator + readme updates
tutors-sdk#722: support "archive" and "archives" in lab/notes
search result ux changes + support for PDF labs + package updates (excluding partykit for the moment)
Supabase & PartyKit library updates (+others)
@lgriffin
Copy link
Contributor Author

Hmmm not sure what git has done here going to close this and figure it out!

@lgriffin lgriffin closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants