Add --32bit flag
#27
Open
Add --32bit flag
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tusharsadhwani
commented
Jun 29, 2024
•
tusharsadhwani
commented
- fix all todos
|
I would be willing to help test |
LexiconCode
reviewed
Aug 14, 2024
| # already installed | ||
| python_bin_path = _python_bin_path(python_folder) | ||
| return python_folder_name, python_bin_path | ||
| if force_32bit and python_folder_name.endswith(SUFFIX_32BIT): |
There was a problem hiding this comment.
When using force_32bit the python_folder_name does not have a 32bit suffix.
Steps to reproduce:
ensure_python(python_version = 3.10.14, force_32bit = false)ensure_python(python_version = 3.10.14, force_32bit = true)- The
32bitpython environment overwrites the64bitpython environment in.yen_pythons
There was a problem hiding this comment.
thanks for catching this! I'll be working on this pr later today.
There was a problem hiding this comment.
Well looks like I missed your todo # TODO: use suffix_32bit here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.