Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit proposal and store in IPFS #95

Merged
merged 20 commits into from
Dec 2, 2024
Merged

Conversation

0xExp-po
Copy link
Contributor

create new proposal page

  • add markdown editor
  • upload image and store info
  • add outcome input
  • prepare files to submit

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for testnet-tansu ready!

Name Link
🔨 Latest commit 97d5dac
🔍 Latest deploy log https://app.netlify.com/sites/testnet-tansu/deploys/674d475df14ca50008c4eacf
😎 Deploy Preview https://deploy-preview-95--testnet-tansu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76
Accessibility: 88
Best Practices: 92
SEO: 85
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for tansu canceled.

Name Link
🔨 Latest commit 97d5dac
🔍 Latest deploy log https://app.netlify.com/sites/tansu/deploys/674d475dae812f00083983c7

@0xExp-po
Copy link
Contributor Author

fix latest commit check badge error

dapp/src/env.d.ts Outdated Show resolved Hide resolved
dapp/src/pages/api/w3up-delegation.js Outdated Show resolved Hide resolved
@tupui
Copy link
Owner

tupui commented Dec 1, 2024

I could check locally. Seems to be working good. Just a few things like lists not rendering on the preview, but we can skip that for now.

Most important is the following:

  • Right now it seems like anyone can submit a proposal. We don't want that, we only want to allow maintainers to create a proposal. Please make the create and submit only work if a maintainer is connected.

  • The delegation need to be valid for as little as possible. E.g. 10s.

  • Check if you can restrict the permissions to only submit a single proposal.

  • After a proposal is submitted, we should be redirected to the governance page.

I will merge after these are fixed.


After looking at the doc of storacha a bit more, I think that what we will want to do is this https://web3.storage/docs/how-to/create-account/ Use the CLI to create an account for a project and then use the login via email method to get the delegation https://web3.storage/docs/how-to/upload/#claim-delegations-via-email-validation This way we also have a separate space for each project which is cleaner.

For now this is ok as we are using the free tier and we can block the service if people start to abuse it. I will make an issue for that part.

@tupui tupui added enhancement New feature or request dao labels Dec 1, 2024
@tupui tupui linked an issue Dec 1, 2024 that may be closed by this pull request
Copy link
Owner

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's get this in 🚀

@tupui tupui merged commit 7486a36 into tupui:main Dec 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dao enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store proposals on IPFS
2 participants