Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp commit history #38

Merged
merged 54 commits into from
Sep 10, 2024
Merged

dApp commit history #38

merged 54 commits into from
Sep 10, 2024

Conversation

0xExp-po
Copy link
Contributor

@0xExp-po 0xExp-po commented Sep 5, 2024

  • add get project info function and display project info
  • add router to 'commit' or 'register'
  • add update config modal and function
  • keep display connected wallet
  • rebase holder structure and update tailwindcss config file
  • add commit history view section

Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for tansu canceled.

Name Link
🔨 Latest commit e736ac1
🔍 Latest deploy log https://app.netlify.com/sites/tansu/deploys/66e01619cc450c00088a38d2

Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for testnet-tansu ready!

Name Link
🔨 Latest commit e736ac1
🔍 Latest deploy log https://app.netlify.com/sites/testnet-tansu/deploys/66e016196615700008ffd5a7
😎 Deploy Preview https://deploy-preview-38--testnet-tansu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 81
Accessibility: 91
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@tupui
Copy link
Owner

tupui commented Sep 5, 2024

Thanks, this looks really great! I like the history view 😃 🙌

Starting with a visual review and then I will go through the code in more details once a few things are fixed.

Connect wallet

  • keep display connected wallet

Great fix!

Linked to the connect, I noticed that if you select a project, then connect your wallet, the update config button does not appear. You need to navigate back and select again the project.

Screenshot 2024-09-05 at 22 14 56

On-chain button

Out of scope but maybe you can quickly fix that button when navigating back it does not show properly

Screenshot 2024-09-05 at 22 11 44

Most importantly, the link is broken as it goes to https://stellar.expert/explorer/undefined/contract/undefined. Looks like the previous update broke it as the live version is also broken.

Project name

There is still a duplicate name here

Screenshot 2024-09-05 at 22 11 12

Please just remove the name from the topic component so that it looks like that. The name is enough in the other section. Also please reduce the font weight for the name as it's a bit disproportionate compared to the rest.

Screenshot 2024-09-05 at 12 24 26

History view

Ok this is cool! 😃

  1. Is there some pagination or scrolling logic? We need to show at most a few commits to not have an infinite list there.
  2. Can you highlight the commit which corresponds to the hash on-chain?
  3. Linked to that, it would be good to have a jump to button which would navigate the view to this commit if it's down or on another page.
Screenshot 2024-09-05 at 22 13 23

@0xExp-po
Copy link
Contributor Author

0xExp-po commented Sep 6, 2024

  • I'll figure out the wallet connection problem
  • I've fixed project name error
  • on chain button is working well in my side but I'll take a look carefully again
  • now I've just shown 30 commits and I'll add scroll there
  • I'll implement highlight option
  • now the commit message, author name, commit sha, and copy to clipboard are working

@0xExp-po
Copy link
Contributor Author

0xExp-po commented Sep 6, 2024

I've fixed bugs based on your feedback

  • now you can connect your wallet after setting project
  • I added scrollbar if there are many commits
  • I made the latest commit highlighted

Add some extra function

  • store the project info in local storage so that keep the status after refresh page
  • divide project service file into two files: project service for contract interaction and state service for global variables management

Copy link
Owner

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, there seems to be a wrong path or missing piece of code as an import is failing. I will be able to really review once I can see the preview. I still left some comments.

import { formatDate } from '../service/utils';
import type { FormattedCommit } from '../types/github';

const commitHistory = await getCommitHistory('tupui', 'soroban-versioning');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I understand why this is set to 'tupui', 'soroban-versioning'. We want to fetch the history of the project people would select, not of tupui/soroban-versioning. This is missing a props or something else so that it points to the GitHub of the selected project (url in the config like in the Project info section).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you're right
that's why I said I used demo data
I've developed function to get dynamic info user selects and testing now
after test, I'll push it too

dapp/src/constants/CommitHistory.js Outdated Show resolved Hide resolved
dapp/src/service/utils.ts Outdated Show resolved Hide resolved
@tupui
Copy link
Owner

tupui commented Sep 7, 2024

Thanks for the updates I could check all that. (Scrolling not sure but can be left for the next step on UI.)

Then it's just missing the jump to latest hash button and working for any project you set. After that we can merge.

@tupui tupui added this to the dApp milestone Sep 9, 2024
@tupui tupui changed the title add some functions and sections in dapp dApp commit history Sep 9, 2024
@0xExp-po
Copy link
Contributor Author

I've fixed register bug
also, fixed invoking latest sha function in commit record

Copy link
Owner

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM now 🚀

@tupui tupui merged commit 0fae9b1 into tupui:main Sep 10, 2024
11 of 12 checks passed
@tupui tupui linked an issue Sep 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

dApp history view
2 participants