-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dapp code according to tupui's review #37
Conversation
0xExp-po
commented
Sep 4, 2024
- I've fixed code according to your review
Co-authored-by: Pamphile Roy <[email protected]>
✅ Deploy Preview for tansu canceled.
|
✅ Deploy Preview for testnet-tansu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a minor thing and it's good to go.
Please push new commits on this branch for updates instead of closing and making a new PR 😃 Otherwise I need to go through the changes again
--- | ||
|
||
<div class="relative flex flex-col items-center md:flex-row justify-between"> | ||
<Topic title="Project Information" description="" id="project-name-topic"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry maybe I was not clear. This should look like this.
<Topic title="Project Information" description="" id="project-name-topic"/> | |
<Topic title="Project" description="Details about the project" id="project-name-topic"/> |
And when you get the name it should appear in another div right above the list of maintainers. So around L25 here.
Can be like you have in the modal to update the config basically.
); | ||
|
||
if (updateStatus) { | ||
updateProjectInfo(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a follow up, I think it should also reload the project info. And same as with the other buttons, it should add the spinner component so users know something happened after they clicked the button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, looks great 🚀